GNOME Bugzilla – Bug 763605
Don't ask to unlock if the device is already unlocked
Last modified: 2016-06-09 10:01:07 UTC
The "Try again" message only mentions unlocking the phone with a passcode, and not with TouchID: message = g_strdup_printf (_("The device “%s” is locked. Enter the passcode on the device and click “Try again”."), display_name); We'd need to do something similar to: http://stackoverflow.com/questions/26026563/ios8-check-if-device-has-touch-id but from the remote side. We might also want to mention the need to press the "Trust" button.
I have no idea how this works in detail, but it seems to me it isn't necessary to check whether the device has TouchID or not. Wouldn't be enough to just change the message as follows? "The device “%s” is locked. Unlock the device, press the “Trust” button and click “Try again”."
Either way, we'll need to change the message. So what the message ends up being depends on what the device offers as hints.
Created attachment 329206 [details] [review] afc: Add pairing dialogue specific message When a pairing dialogue is shown on the device, don't tell the user that the device is locked, rather that they need to click "Trust".
Review of attachment 329206 [details] [review]: This somehow makes sense with the patch from Bug 767297, however I would merge those patches and replace the code by one switch... ::: daemon/gvfsbackendafc.c @@ +615,3 @@ + message = g_strdup_printf (_("The device “%s” is locked. Enter the passcode on the device and click “Try again”."), display_name); + } + else if (lerr == LOCKDOWN_E_PAIRING_DIALOG_PENDING) LOCKDOWN_E_PAIRING_DIALOG_RESPONSE_PENDING?
Created attachment 329281 [details] [review] afc: Add pairing dialogue specific message When a pairing dialogue is shown on the device, don't tell the user that the device is locked, rather that they need to click "Trust".
Review of attachment 329281 [details] [review]: Ok, looks good!
(In reply to Ondrej Holy from comment #4) > Review of attachment 329206 [details] [review] [review]: > > This somehow makes sense with the patch from Bug 767297, however I would > merge those patches and replace the code by one switch... String freeze break... One I can commit to gnome-3-20, the other not.
Created attachment 329375 [details] [review] afc: Add specific errors for trust dialogue errors Add specific errors for when the user refuses trust on the device, or repeatedly tries to connect to it but the device is locked, or the dialogue still showing on the device.
Created attachment 329376 [details] [review] afc: Add specific errors for trust dialogue errors Add specific errors for when the user refuses trust on the device, or repeatedly tries to connect to it but the device is locked, or the dialogue still showing on the device.
Review of attachment 329376 [details] [review]: Ok
Attachment 329281 [details] pushed as 77dbecd - afc: Add pairing dialogue specific message Attachment 329376 [details] pushed as df8a093 - afc: Add specific errors for trust dialogue errors