After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767157 - dvdemux: Pass-through buffer DISCONT flags and recalculate frame offsets when needed
dvdemux: Pass-through buffer DISCONT flags and recalculate frame offsets when...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-02 11:21 UTC by Sebastian Dröge (slomo)
Modified: 2016-06-03 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dvdemux: Pass-through buffer DISCONT flags (3.33 KB, patch)
2016-06-02 11:21 UTC, Sebastian Dröge (slomo)
none Details | Review
dvdemux: Recalculate the frame offsets at the beginning of each BYTE segment and whenever upstream gives us a timestamp (3.54 KB, patch)
2016-06-02 11:21 UTC, Sebastian Dröge (slomo)
none Details | Review
dvdemux: Recalculate the frame offsets at the beginning of each BYTE segment and whenever upstream gives us a timestamp (3.58 KB, patch)
2016-06-02 12:14 UTC, Sebastian Dröge (slomo)
none Details | Review
dvdemux: Pass-through buffer DISCONT flags (3.33 KB, patch)
2016-06-03 07:39 UTC, Sebastian Dröge (slomo)
committed Details | Review
dvdemux: Recalculate the frame offsets at the beginning of each BYTE segment and whenever upstream gives us a timestamp (3.58 KB, patch)
2016-06-03 07:39 UTC, Sebastian Dröge (slomo)
committed Details | Review
dvdemux: Implement SEEKING query so we can actually seek if upstream can't seek in TIME (2.33 KB, patch)
2016-06-03 07:39 UTC, Sebastian Dröge (slomo)
committed Details | Review
dvdemux: Remember if upstream had a time segment and if not properly create time segments (3.84 KB, patch)
2016-06-03 07:39 UTC, Sebastian Dröge (slomo)
committed Details | Review
dvdemux: Properly set event/message sequence numbers based on the previous seek (8.79 KB, patch)
2016-06-03 07:50 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2016-06-02 11:21:44 UTC
See commit messages
Comment 1 Sebastian Dröge (slomo) 2016-06-02 11:21:48 UTC
Created attachment 328941 [details] [review]
dvdemux: Pass-through buffer DISCONT flags
Comment 2 Sebastian Dröge (slomo) 2016-06-02 11:21:54 UTC
Created attachment 328942 [details] [review]
dvdemux: Recalculate the frame offsets at the beginning of each BYTE segment and whenever upstream gives us a timestamp

This fixes seeking in DV streams where upstream operates in PUSH mode with a
TIME segment (e.g. avidemux). Without this, we would generate wrong durations
and timestamps after a seek.
Comment 3 Sebastian Dröge (slomo) 2016-06-02 12:14:38 UTC
Created attachment 328944 [details] [review]
dvdemux: Recalculate the frame offsets at the beginning of each BYTE segment and whenever upstream gives us a timestamp

This fixes seeking in DV streams where upstream operates in PUSH mode with a
TIME segment (e.g. avidemux). Without this, we would generate wrong durations
and timestamps after a seek.
Comment 4 Sebastian Dröge (slomo) 2016-06-03 07:39:02 UTC
Created attachment 329017 [details] [review]
dvdemux: Pass-through buffer DISCONT flags
Comment 5 Sebastian Dröge (slomo) 2016-06-03 07:39:08 UTC
Created attachment 329018 [details] [review]
dvdemux: Recalculate the frame offsets at the beginning of each BYTE segment and whenever upstream gives us a timestamp

This fixes seeking in DV streams where upstream operates in PUSH mode with a
TIME segment (e.g. avidemux). Without this, we would generate wrong durations
and timestamps after a seek.
Comment 6 Sebastian Dröge (slomo) 2016-06-03 07:39:13 UTC
Created attachment 329019 [details] [review]
dvdemux: Implement SEEKING query so we can actually seek if upstream can't seek in TIME
Comment 7 Sebastian Dröge (slomo) 2016-06-03 07:39:19 UTC
Created attachment 329020 [details] [review]
dvdemux: Remember if upstream had a time segment and if not properly create time segments

Previously the segment.time was wrong, and the position was not updated
correctly, resulting in seeks in PUSH mode with upstream providing a BYTES
segment to not work at all.
Comment 8 Sebastian Dröge (slomo) 2016-06-03 07:50:17 UTC
Created attachment 329021 [details] [review]
dvdemux: Properly set event/message sequence numbers based on the previous seek

See https://bugzilla.gnome.org/show_bug.cgi?id=765935
Comment 9 Sebastian Dröge (slomo) 2016-06-03 10:19:38 UTC
Attachment 329017 [details] pushed as 30c8aaf - dvdemux: Pass-through buffer DISCONT flags
Attachment 329018 [details] pushed as 2f4b89f - dvdemux: Recalculate the frame offsets at the beginning of each BYTE segment and whenever upstream gives us a timestamp
Attachment 329019 [details] pushed as 479a3ba - dvdemux: Implement SEEKING query so we can actually seek if upstream can't seek in TIME
Attachment 329020 [details] pushed as 26b37c7 - dvdemux: Remember if upstream had a time segment and if not properly create time segments
Attachment 329021 [details] pushed as d62115e - dvdemux: Properly set event/message sequence numbers based on the previous seek