After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765935 - ges:tests:validate: Add tests disabling mixing in the default testsuite
ges:tests:validate: Add tests disabling mixing in the default testsuite
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-editing-services
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-03 11:37 UTC by Thibault Saunier
Modified: 2018-11-03 12:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests:validate: Add tests disabling mixing in the default testsuite (8.01 KB, patch)
2016-05-03 11:37 UTC, Thibault Saunier
none Details | Review

Description Thibault Saunier 2016-05-03 11:37:49 UTC
We should test that GES is useable even when disable mixing, meaning that
Gst elements, and in particular demuxers properly handle seqnums as NLE
intensively relies on them to thread safely know when a sub pipeline is
EOS.
Comment 1 Thibault Saunier 2016-05-03 11:37:54 UTC
Created attachment 327211 [details] [review]
tests:validate: Add tests disabling mixing in the default testsuite

And make the file pep8 compliant
Comment 2 Sebastian Dröge (slomo) 2016-05-18 14:44:54 UTC
Various demuxers don't pass through the seqnums yet, for example mpeg(ps)demux :) A lot of stuff is failing and needs fixing
Comment 3 Thibault Saunier 2016-05-18 14:51:20 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> Various demuxers don't pass through the seqnums yet, for example
> mpeg(ps)demux :) A lot of stuff is failing and needs fixing

Yeah, untapping those issue is what that bug is about ;)
Comment 4 Sebastian Dröge (slomo) 2016-05-20 06:37:41 UTC
Also avidemux has no support for passing through seqnums
Comment 5 Sebastian Dröge (slomo) 2016-05-20 08:17:18 UTC
Some related changes:

commit 7cd9d34c80d9dace2671db4fb24ff19ca71c2584
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri May 20 11:15:44 2016 +0300

    qtdemux: Set seek event seqnum on all SEGMENT events
    
    Some were forgotten.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=765935

commit 9e5cda59f82d6a2abb4186a7ce7061437e9c23ff
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri May 20 11:12:44 2016 +0300

    avidemux: Pass through seek event seqnums in all SEGMENT/EOS events and SEGMENT_DONE messages/events
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=765935

commit 0345ba78f5cf72ef0be2f8b989e57dd73f7f27f4
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri May 20 10:56:52 2016 +0300

    matroskademux: Set seek event seqnum in EOS and SEGMENT_DONE messages/events
    
    Also actually store the seqnum in pull mode seeks.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=765935
Comment 6 Sebastian Dröge (slomo) 2016-05-20 08:22:01 UTC
Known still broken: flvdemux, mpeg(ps)demux
Probably broken: tsdemux, mxfdemux, dvdemux, oggdemux, asfdemux, rademux/rmdemux
Comment 7 Sebastian Dröge (slomo) 2016-06-03 10:11:55 UTC
Patch in bug #767157 fixes it for dvdemux, remaining:

Known still broken: flvdemux, mpeg(ps)demux
Probably broken: tsdemux, mxfdemux, oggdemux, asfdemux, rademux/rmdemux
Comment 8 GStreamer system administrator 2018-11-03 12:53:11 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/25.