After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767148 - Keep the search bar visible in the search view
Keep the search bar visible in the search view
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-02 09:37 UTC by Joaquim Rocha
Modified: 2016-06-02 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a public function to set the search bar visibility in GsShell (2.59 KB, patch)
2016-06-02 09:37 UTC, Joaquim Rocha
none Details | Review
Fix showing the search bar in the search view (999 bytes, patch)
2016-06-02 09:37 UTC, Joaquim Rocha
none Details | Review

Description Joaquim Rocha 2016-06-02 09:37:40 UTC
When search results are shown (either with apps or empty), the search bar is hidden is very frustrating. Looking into the code it seems like this is not happening on purpose but due to the code that shows the search bar in the search view not have been updated when the search bar became a revealer.
Comment 1 Joaquim Rocha 2016-06-02 09:37:45 UTC
Created attachment 328934 [details] [review]
Add a public function to set the search bar visibility in GsShell

This will be useful to control the search bar visibility from different
places in the shell.

Also use the function to replace the code that shows/hides the search
bar in GsShell.
Comment 2 Joaquim Rocha 2016-06-02 09:37:56 UTC
Created attachment 328935 [details] [review]
Fix showing the search bar in the search view

The search bar needs to be revealed instead of just shown after it
switched to a revealer widget.
Comment 3 Richard Hughes 2016-06-02 12:06:32 UTC
commit d479fe2e9e2bcd2e13813642f4d39010b9722b81
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Jun 2 13:01:00 2016 +0100

    Switch to using GtkSearchBar
    
    Fixes:
    https://bugzilla.gnome.org/show_bug.cgi?id=767143
    https://bugzilla.gnome.org/show_bug.cgi?id=767144
    https://bugzilla.gnome.org/show_bug.cgi?id=767146
    https://bugzilla.gnome.org/show_bug.cgi?id=767148