After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767144 - Fix toggling the search bar button
Fix toggling the search bar button
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-02 09:27 UTC by Joaquim Rocha
Modified: 2016-06-02 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Keep a pointer to the search bar in the GsShellOverview's private (2.57 KB, patch)
2016-06-02 09:27 UTC, Joaquim Rocha
none Details | Review
Toggle the search button when the search bar visibility changes (1.78 KB, patch)
2016-06-02 09:27 UTC, Joaquim Rocha
none Details | Review

Description Joaquim Rocha 2016-06-02 09:27:22 UTC
When a key is pressed in the overview and the search bar is shown, the search is not toggled.
Comment 1 Joaquim Rocha 2016-06-02 09:27:27 UTC
Created attachment 328930 [details] [review]
Keep a pointer to the search bar in the GsShellOverview's private

This is useful to refer to the search bar without having to use
the GtkBuilder all the time.

Also change the calls to the builder by the new search bar pointer.
Comment 2 Joaquim Rocha 2016-06-02 09:27:32 UTC
Created attachment 328931 [details] [review]
Toggle the search button when the search bar visibility changes

The search button reveals the search bar but since the latter also gets
revealed by simply typing in the overview, then the button should be
toggled to reflect the state of the search bar visibility.
Comment 3 Richard Hughes 2016-06-02 12:06:20 UTC
commit d479fe2e9e2bcd2e13813642f4d39010b9722b81
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Jun 2 13:01:00 2016 +0100

    Switch to using GtkSearchBar
    
    Fixes:
    https://bugzilla.gnome.org/show_bug.cgi?id=767143
    https://bugzilla.gnome.org/show_bug.cgi?id=767144
    https://bugzilla.gnome.org/show_bug.cgi?id=767146
    https://bugzilla.gnome.org/show_bug.cgi?id=767148