After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767048 - Syntax error in Vapi file
Syntax error in Vapi file
Status: RESOLVED DUPLICATE of bug 765785
Product: vala
Classification: Core
Component: Bindings: GTK+ GStreamer WebKitGTK+
0.32.x
Other All
: Normal major
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-31 00:38 UTC by Chris Daley
Modified: 2016-05-31 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Diff file to correct Vapi file errror (893 bytes, patch)
2016-05-31 00:38 UTC, Chris Daley 		none Details | Review

Description Chris Daley 2016-05-31 00:38:22 UTC 
Created attachment 328772 [details] [review]
Diff file to correct Vapi file errror

Line 39 of gstreamer-controller-1.0.vapi has a spurious extra do which will cause Vala to throw and error. Patch attached.
Comment 1 Al Thomas 2016-05-31 14:25:00 UTC 
Thanks for your patch. This is a duplicate of 
https://bugzilla.gnome.org/show_bug.cgi?id=765785

The gstreamer-controller binding is generated from GIR files with vapigen. The metadata in https://git.gnome.org/browse/vala/tree/vapi/metadata/GstController-1.0.metadata has an additional dot that needs removing. The submitter on the bug report has a patch that updates that and also renames the function to just 'with_absolute'. Is that in keeping with current naming conventions?
Comment 2 Chris Daley 2016-05-31 14:42:19 UTC 
I'm not sure what the actual naming conventions are but in general if the creation method is static (i.e from a Factory) or is a Struct then it should have "new" in the method name, otherwise it is redundant. The other patch covers the metadata in any case so this bug can probably be safely closed.

*** This bug has been marked as a duplicate of bug 765785 ***