After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765785 - gstreamer-controller-1.0: rename DirectControlBinding.new_absolue to 'with_absolute'
gstreamer-controller-1.0: rename DirectControlBinding.new_absolue to 'with_ab...
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GTK+ GStreamer WebKitGTK+
0.32.x
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
: 767048 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-04-28 21:58 UTC by Aurélien Zanelli
Modified: 2016-06-08 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gstreamer-controller-1.0: rename DirectControlBinding.new_absolue to 'with_absolute' (1.89 KB, patch)
2016-04-28 21:59 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2016-04-28 21:58:37 UTC
Current gstreamer-controller-1.0 metadata file rename DirectControlBinding.new_absolute to ".new_with_absolute" which generates an invalid symbol in vapi file. I propose to rename to "with_absolute" which gives:
DirectControlBinding.with_absolute
Comment 1 Aurélien Zanelli 2016-04-28 21:59:30 UTC
Created attachment 326972 [details] [review]
gstreamer-controller-1.0: rename DirectControlBinding.new_absolue to 'with_absolute'
Comment 2 Chris Daley 2016-05-31 14:42:19 UTC
*** Bug 767048 has been marked as a duplicate of this bug. ***
Comment 3 Al Thomas 2016-05-31 15:30:19 UTC
Review of attachment 326972 [details] [review]:

Thanks for you patch. Looks good.

Patch removes the additional dot in the metadata. It also makes a sensible change to the name of the creation method. So now it will be:
var a = new DirectControlBinding.with_absolute( ... );
instead of 
var a = new DirectControlBinding.new_with_absolute( ... );
Comment 4 Aurélien Zanelli 2016-06-08 12:39:24 UTC
Thanks for review and merge.