After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766134 - Remove notification preferences
Remove notification preferences
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: client
master
Other Linux
: Normal normal
: 0.14.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: 766133
Blocks:
 
 
Reported: 2016-05-08 12:24 UTC by Michael Gratton
Modified: 2019-09-27 10:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Gratton 2016-05-08 12:24:58 UTC 
gnome-control-centre allows the user to centrally manage notification sounds and popups, Geary shouldn't duplicate that UI and codepath.
Comment 1 Niels De Graef 2016-05-09 15:04:07 UTC 
Does this also include *any* kind of sound we produce (at the moment this also
happens when a mail is sent), or only the case where we produce our own sound
for a notification?

If it's the former, this would mean we could remove the libcanberra dependency.

If it's the latter, it might be a good idea to just show a (possibly very quickly
disappearing) notification in case of a mail being sent. Then it is still up to
the user to decide over a sound via gnome-control-center.
Comment 2 Michael Gratton 2016-05-10 00:06:52 UTC 
We want to keep all the existing the sounds, but let gnome-control-center manage whether they are played for notifications.

There's already some reports about the mail-sent sound (Make it a pref - Bug 713889 and make it a notification - Bug 749986) both of which I'm partial to, but if we make mail-sent a notification, then having a pref for it only makes sense if the pref is actually "Notify me when mail is sent". That makes it impossible to beep-on-send and not play sounds for notifications, however.
Comment 3 Michael Gratton 2017-10-11 17:14:30 UTC 
Lets do this once the Bug 766133 lands.
Comment 4 Michael Gratton 2018-06-26 04:48:04 UTC 
Bump tickets to 0.14 that aren't going to make 0.13.
Comment 5 Michael Gratton 2019-09-27 10:48:04 UTC 
Landing in https://gitlab.gnome.org/GNOME/geary/merge_requests/315

Ended up removing both prefs, since using GNotify we have no control over it for notifications anyway, but have enabled writing a plugin that supports playing a sound on send instead.