After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766028 - crash on manual addition of price entry in Price Editor
crash on manual addition of price entry in Price Editor
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Windows
2.6.12
Other Windows
: Normal major
: ---
Assigned To: gnucash-win-maint
gnucash-win-maint
: 764732 790777 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-05-05 14:03 UTC by Ulrich Hopfer
Modified: 2018-06-29 23:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Windows Trace from reported crash (585 bytes, text/plain)
2016-05-17 10:05 UTC, David Carlson
Details

Description Ulrich Hopfer 2016-05-05 14:03:36 UTC
This problem is new in 2.6.12, both Windows and Linux(Ubuntu) OSes. 
The Price Editor works fine in terms of updating fund price data with F::Q and saving the data. Data entry in manual updates of fund prices works fine and can be "applied" so that another entry is possible. However, the program crashes when pressing "OK" to close the manual entry window.
Comment 1 John Ralls 2016-05-05 22:09:41 UTC
Can't replicate on OSX, and away from other OSes until next week. Can you run under gdb on Linux and post a stack trace? http://wiki.gnucash.org/wiki/Stack_Trace.
Comment 2 Ulrich Hopfer 2016-05-06 00:24:42 UTC
Here is the windows report

Problem signature:
  Problem Event Name:	APPCRASH
  Application Name:	gnucash.exe
  Application Version:	0.0.0.0
  Application Timestamp:	56f898df
  Fault Module Name:	msvcrt.dll
  Fault Module Version:	7.0.9600.17415
  Fault Module Timestamp:	54504b2e
  Exception Code:	c0000005
  Exception Offset:	0001bf8f
  OS Version:	6.3.9600.2.0.0.768.101
  Locale ID:	1033
  Additional Information 1:	5861
  Additional Information 2:	5861822e1919d7c014bbb064c64908b2
  Additional Information 3:	1318
  Additional Information 4:	13181ae637ac2592fac0ca2dd662cdcc

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=280262

If the online privacy statement is not available, please read our privacy statement offline:
  C:\WINDOWS\system32\en-US\erofflps.txt
Comment 3 Ulrich Hopfer 2016-05-06 00:33:48 UTC
Correction to the original report:  The reported problem is specific for windows - Linux works ok (my apologies for incorrectly reporting a problem in Linux.
Ulrich
Comment 4 John Ralls 2016-05-06 02:07:17 UTC
Unfortunately we use MinGW and so M$ crash reports aren't helpful. This will have to wait until I get home next week and can try to replicate it on a Windows VM unless you can generate a stack trace in the meantime.
Comment 5 David Wilson 2016-05-06 22:38:19 UTC
I use Linux ubuntu 16:04

I get a segfault every time I try to add a new price using the price editor.

Here is the gdb backtrace:


Thread 1 "gnucash" received signal SIGSEGV, Segmentation fault.
0x00007ffff72cbfa3 in gnc_price_ref (p=0x1) at gnc-pricedb.c:288
288         p->refcount++;
(gdb) bt
  • #0 gnc_price_ref
    at gnc-pricedb.c line 288
  • #1 gnc_pricedb_lookup_latest
    at gnc-pricedb.c line 1391
  • #2 account_latest_price
    at gnc-split-reg.c line 514
  • #3 gsr_redraw_all_cb
    at gnc-split-reg.c line 611
  • #4 ??
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #5 g_signal_emit_valist
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #6 g_signal_emit_by_name
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #7 gnucash_sheet_redraw_all
    at gnucash-sheet.c line 650
  • #8 gnc_table_refresh_gui
    at table-gnome.c line 241
  • #9 gnc_split_register_load
    at split-register-load.c line 713
  • #10 gnc_ledger_display_refresh_internal
    at gnc-ledger-display.c line 833
  • #11 refresh_handler
    at gnc-ledger-display.c line 584
  • #12 gnc_gui_refresh_internal
    at gnc-component-manager.c line 714
  • #13 gnc_gui_refresh_all
    at gnc-component-manager.c line 752
  • #14 pedit_dialog_response_cb
    at dialog-price-editor.c line 292
  • #15 g_closure_invoke
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #16 ??
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #17 g_signal_emit_valist
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #18 g_signal_emit
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #19 ??
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #20 g_signal_emit_valist
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #21 g_signal_emit
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #22 ??
    from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
  • #23 g_closure_invoke
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #24 ??
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #25 g_signal_emit_valist
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #26 g_signal_emit
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #27 ??
    from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
  • #28 ??
    from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
  • #29 g_closure_invoke
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
  • #30 ??
    from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0

Comment 6 Donald McAdams 2016-05-07 15:01:29 UTC
My experience (windows) was that the "OK" button worked as long as the "apply" button wasn't selected ... meaning only 1 price addition could be applied at a time.
Comment 7 David Wilson 2016-05-07 23:33:13 UTC
(In reply to David Wilson from comment #5)
> I use Linux ubuntu 16:04
> 
> I get a segfault every time I try to add a new price using the price editor.
> 
> Here is the gdb backtrace:
> 
> 
> Thread 1 "gnucash" received signal SIGSEGV, Segmentation fault.
> 0x00007ffff72cbfa3 in gnc_price_ref (p=0x1) at gnc-pricedb.c:288
> 288         p->refcount++;
> (gdb) bt

As reported by Donald McAdams the crash (on Linux) occurs on clicking the Apply button, but seems to correctly add the price with the "OK" button.

Also I should have stated that  I am using GnuCash 2.6.12, built from rev ed11f6d+ on 2016-05-07.
Comment 8 Ulrich Hopfer 2016-05-08 01:56:20 UTC
In reply to Donald McAdams with windows: Thanks for letting me know about the problem with the "apply" button. The Price Editor works fine with just 1 manual edition and the pressing "ok" without using "apply". In a previous version (2.4), the "apply" button worked fine and several manual editions could be made at a time.
Comment 9 John Ralls 2016-05-10 20:46:05 UTC
I've pushed a fix that will be in tomorrow's nightly maint build, please test.

Work around is to use "Cancel" instead of "OK" if the Apply button is greyed out.
Comment 10 Ulrich Hopfer 2016-05-11 02:13:06 UTC
John,

I am a newbie here. Will the nightly maint build be on github? Ulrich
Comment 11 John Ralls 2016-05-11 02:49:50 UTC
(In reply to Ulrich Hopfer from comment #10)
> John,
> 
> I am a newbie here. Will the nightly maint build be on github? Ulrich

No, Win32 will be in 
http://code.gnucash.org/builds/win32/maint/
and an rpm should be at 
https://copr.fedorainfracloud.org/coprs/gjanssens/gnucash-maint/builds/
but that seems to be broken--the last one was over 3 weeks ago.
Comment 12 Geert Janssens 2016-05-11 07:06:34 UTC
The rpm builds were broken because my login token had expired. Tried to fix that last week but failed. I just now realized I tried to fix it on the wrong server...

I have manually started the rpm builds a minute ago from the most recent maint and master branch. They should be available in an hour or so.
Comment 13 Ulrich Hopfer 2016-05-12 00:47:51 UTC
John,

the latest build in http://code.gnucash.org/builds/win32/maint/ is from 4/17/2016.
I do not see your build from 5/10/16.
Comment 14 John Ralls 2016-05-12 01:01:13 UTC
It would be the 5/11 build which failed from a change in the documentation. I'll look at it tomorrow, which means the nightly will be Friday or Saturday.
Comment 15 Wm 2016-05-14 18:49:29 UTC
(In reply to John Ralls from comment #9)
> I've pushed a fix that will be in tomorrow's nightly maint build, please
> test.
> 
> Work around is to use "Cancel" instead of "OK" if the Apply button is greyed
> out.

I think there were a few related things going on here as I had a different symptom.  To test I built
master + cherry pick your fix [1]
on linux and it is behaving as I expect.

Be nice to have a Win test as and when so other people can check if their symptom is fixed too but I think it is right now.

[1] a first for me, I still find chunks of git confusing
Comment 16 John Ralls 2016-05-14 18:55:22 UTC
The symptoms do vary, apparently depending upon how memory was allocated and freed; that will in turn depend on the versions of (g)libc and glib. There was no corruption at all on OS X.

Why did you cherry pick to master instead of just building maint?

BTW, for those waiting for a Window nightly build, that build is still broken due to a completely unrelated problem with building the documents. I'm working on it but the excruciating slowness of the Win32 build VM makes it an excessively long task.
Comment 17 Wm 2016-05-14 19:30:20 UTC
(In reply to John Ralls from comment #16)
> The symptoms do vary, apparently depending upon how memory was allocated and
> freed; that will in turn depend on the versions of (g)libc and glib. There
> was no corruption at all on OS X.

That makes sense, I had differing symptoms with my main book and a tiny test book with half a dozen prices.

> Why did you cherry pick to master instead of just building maint?

1. no (or known) crap if I used it to change my live book
2. it was a good chance for me to think some more about git rather than just using it to get and build (and I know that get isn't the git word)

> BTW, for those waiting for a Window nightly build, that build is still
> broken due to a completely unrelated problem with building the documents.
> I'm working on it but the excruciating slowness of the Win32 build VM makes
> it an excessively long task.

Coincidentally and tangentially I'm having another go at building under Win64 Cygwin because of Win32 VM slowness (and Win64 possibly not working at all). Will report in dev as and when.
Comment 18 David Carlson 2016-05-17 10:03:24 UTC
I thought that I would test this for you but I can only find the official release release build (2016-03-27) right now.  Both the nightly Windows builds are still stuck in April.

For me in Windows 7 the official build crashed when I opened the price editor, selected an existing price for an existing security, clicked on Add then in the Add dialog, clicked OK without making any other changes in that dialog.
Comment 19 David Carlson 2016-05-17 10:05:44 UTC
Created attachment 328053 [details]
Windows Trace from reported crash
Comment 21 Ulrich Hopfer 2016-05-19 02:44:18 UTC
John,
thanks. The new windows nightly build solved the problem of a crash on manual addition of price entry in Price Editor.
Comment 22 John Ralls 2016-05-19 03:27:29 UTC
Yay. It will of course also be in the next normal release.
Comment 23 John Ralls 2016-06-05 15:26:18 UTC
*** Bug 764732 has been marked as a duplicate of this bug. ***
Comment 24 John Ralls 2018-01-14 17:18:16 UTC
*** Bug 790777 has been marked as a duplicate of this bug. ***
Comment 25 John Ralls 2018-06-29 23:48:58 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=766028. Please update any external references or bookmarks.