After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765547 - GtkApplication improvements
GtkApplication improvements
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-25 15:50 UTC by Cosimo Cecchi
Modified: 2017-04-04 02:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Cosimo Cecchi 2016-04-25 15:50:29 UTC
Mentioned by Allison on bug 765518:

gnome-font-viewer is not particularly awesome as a GtkApplication user.

I recommend the following main fixes:

 - don't override ::quit_mainloop

 - move FcInit and FcFini to ::startup resp. ::shutdown

 - don't create the main window in ::startup
Comment 1 Cosimo Cecchi 2017-04-04 02:45:11 UTC
This is now done in master. Closing as FIXED.