GNOME Bugzilla – Bug 765518
font-view: use GApplication commandline handling
Last modified: 2016-04-25 15:51:11 UTC
Use GApplication's internal handling of commandline arguments. This means that --gapplication-service (which we depend on for DBus activation) will be properly supported. The only reason this was working before is because we were not actually being D-Bus activated due to having a '-' in our app id. With the fix of bug 764754 this is no longer the case, and gnome-font-viewer will be broken.
Created attachment 326665 [details] [review] font-view: use GApplication commandline handling
Review of attachment 326665 [details] [review]: Thanks, looks good.
Attachment 326665 [details] pushed as acf919c - font-view: use GApplication commandline handling
The immediate problem is solved, but gnome-font-viewer is not particularly awesome as a GtkApplication user. I recommend the following main fixes: - don't override ::quit_mainloop - move FcInit and FcFini to ::startup resp. ::shutdown - don't create the main window in ::startup
Thanks for the suggestions! I opened a follow up issue: https://bugzilla.gnome.org/show_bug.cgi?id=765547