After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765518 - font-view: use GApplication commandline handling
font-view: use GApplication commandline handling
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-25 07:48 UTC by Allison Karlitskaya (desrt)
Modified: 2016-04-25 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
font-view: use GApplication commandline handling (2.19 KB, patch)
2016-04-25 07:48 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2016-04-25 07:48:54 UTC
Use GApplication's internal handling of commandline arguments.  This
means that --gapplication-service (which we depend on for DBus
activation) will be properly supported.

The only reason this was working before is because we were not actually
being D-Bus activated due to having a '-' in our app id.  With the fix
of bug 764754 this is no longer the case, and gnome-font-viewer will be
broken.
Comment 1 Allison Karlitskaya (desrt) 2016-04-25 07:48:57 UTC
Created attachment 326665 [details] [review]
font-view: use GApplication commandline handling
Comment 2 Cosimo Cecchi 2016-04-25 08:57:04 UTC
Review of attachment 326665 [details] [review]:

Thanks, looks good.
Comment 3 Allison Karlitskaya (desrt) 2016-04-25 09:38:14 UTC
Attachment 326665 [details] pushed as acf919c - font-view: use GApplication commandline handling
Comment 4 Allison Karlitskaya (desrt) 2016-04-25 09:40:36 UTC
The immediate problem is solved, but gnome-font-viewer is not particularly awesome as a GtkApplication user.

I recommend the following main fixes:

 - don't override ::quit_mainloop

 - move FcInit and FcFini to ::startup resp. ::shutdown

 - don't create the main window in ::startup
Comment 5 Cosimo Cecchi 2016-04-25 15:51:11 UTC
Thanks for the suggestions! I opened a follow up issue: https://bugzilla.gnome.org/show_bug.cgi?id=765547