GNOME Bugzilla – Bug 765082
mikey: add new function gst_mikey_message_to_caps
Last modified: 2016-04-19 15:48:02 UTC
Created attachment 326061 [details] [review] new function gst_mikey_message_to_caps Currently there's a gst_mikey_message_new_from_caps but not the counterpart _to_caps. The _to_caps functionality is currently done in gstsdpmessage. The idea is to move the code from gstsdpmessage to gstmikey and use the new function in gstsdpmessage.
Created attachment 326064 [details] [review] new function gst_mikey_message_to_caps s/gstmikey/mikey/ in commit log
Comment on attachment 326064 [details] [review] new function gst_mikey_message_to_caps When moving, please move it for real in a single commit instead of just duplicating the functionality :) And this bug can probably be merged with bug #765083
(In reply to Sebastian Dröge (slomo) from comment #2) > Comment on attachment 326064 [details] [review] [review] > new function gst_mikey_message_to_caps > > When moving, please move it for real in a single commit instead of just > duplicating the functionality :) And this bug can probably be merged with > bug #765083 Argh... Actually, I had it in a single patch but thought you would prefer having two different commits.
One for the move, one for the new API. Both can be in the same bug :)
(In reply to Sebastian Dröge (slomo) from comment #4) > One for the move, one for the new API. Both can be in the same bug :) Problem is that the other bug has new API too... So, the old functions in bug #765083 use the new functions in bug #765083 plus the functions in this bug.
Created attachment 326066 [details] [review] new function gst_mikey_message_to_caps
Created attachment 326067 [details] [review] new gst_sdp_message_parse_keymgmt/gst_sdp_media_parse_keymgmt
*** Bug 765083 has been marked as a duplicate of this bug. ***
Both patches looks good to me.
Review of attachment 326067 [details] [review]: Please rename, then push :) ::: gst-libs/gst/sdp/gstsdpmessage.c @@ +3816,3 @@ + res = GST_SDP_EINVAL; + if (gst_mikey_message_to_caps (mikey, caps)) + res = sdp_addtributes_to_caps (media->attributes, caps); addtributes? :D
commit 28cf2f02e79676d9ecfb8806401f457d7b6f3b39 Author: Aleix Conchillo Flaqué <aconchillo@gmail.com> Date: Fri Apr 15 00:18:50 2016 -0700 sdpmessage: new gst_sdp_media_parse_keymgmt/gst_sdp_media_parse_keymgmt We add a couple of new functions gst_sdp_media_parse_keymgmt and gst_sdp_media_parse_keymgmt. We also implement gst_sdp_message_attributes_to_caps and gst_sdp_media_attributes_to_caps in terms of these new functions and also gst_mikey_message_to_caps. commit 7a864c177f66ab47852123227d91c7c0d3d827c1 Author: Aleix Conchillo Flaqué <aconchillo@gmail.com> Date: Thu Apr 14 23:29:34 2016 -0700 mikey: add new function gst_mikey_message_to_caps