GNOME Bugzilla – Bug 730540
rtspsrc: parse crypto sessions to support rollover counters
Last modified: 2016-04-19 15:51:07 UTC
Created attachment 276948 [details] [review] parse crypto sessions This patch adds support for parsing the crypto sessions and keeps a map of SSRC and rollover counters. The rollover counters are then used when the request-key signal is emitted by the encoder.
Created attachment 278365 [details] [review] parse crypto sessions commit log fix Add reference to this bug in the commit log.
Created attachment 280873 [details] [review] use srtp rollover counters This keeps the cipher, auth, key and rollover counter maps when parsing MIKEY and updates the caps when the decoder emits the "request-key" signal.
Created attachment 289701 [details] [review] use srtp rollover counters memory leak fixes
Created attachment 326069 [details] [review] add support for srtp rollover counters new patch that depends on bug 765082
Review of attachment 326069 [details] [review]: ::: gst/rtsp/gstrtspsrc.c @@ +2757,3 @@ + + if (ssrc == map->ssrc) { + gst_caps_set_simple (caps, "roc", G_TYPE_UINT, map->roc, NULL); What's so special about the roc that we only need to handle that and none of the others?
(In reply to Sebastian Dröge (slomo) from comment #5) > Review of attachment 326069 [details] [review] [review]: > > ::: gst/rtsp/gstrtspsrc.c > @@ +2757,3 @@ > + > + if (ssrc == map->ssrc) { > + gst_caps_set_simple (caps, "roc", G_TYPE_UINT, map->roc, NULL); > > What's so special about the roc that we only need to handle that and none of > the others? The roc is used for authentication. You only care about the one for your ssrc. https://tools.ietf.org/html/rfc3711#section-4.2 If I understand correctly, in GStreamer, one caps corresponds to one ssrc, so we only need the roc for that specific ssrc.
Comment on attachment 326069 [details] [review] add support for srtp rollover counters Alright!
Comment on attachment 326069 [details] [review] add support for srtp rollover counters commit c36930535d5a20476aaa403477c51c76640a45a1 Author: Aleix Conchillo Flaqué <aleix@oblong.com> Date: Fri Apr 15 00:46:56 2016 -0700 rtspsrc: add srtp rollover counters from mikey crypto sessions The server can send multiple crypto sessions, one for each SSRC with its own rollover counter. We parse this information and pass it to the SRTP decoder via the "request-key" signal. https://bugzilla.gnome.org/show_bug.cgi?id=730540