GNOME Bugzilla – Bug 764165
test_gerror_novalue: Don't define an error - the test doesn't use one
Last modified: 2016-03-24 18:31:38 UTC
Otherwise the build fails with: CHECK Pyflakes examples gi tests pygtkcompat tests/test_gobject.py:689: local variable 'error' is assigned to but never used
Created attachment 324697 [details] [review] test_gerror_novalue: Don't define an error - the test doesn't use one
Review of attachment 324697 [details] [review]: That line still tests that construction doesn't fail, so only the assignment to "error" should be removed.
Somewhat related: bug 764087
Created attachment 324702 [details] [review] test_gerror_novalue: Don't assign the error to a variable Otherwise the build fails with: CHECK Pyflakes examples gi tests pygtkcompat tests/test_gobject.py:689: local variable 'error' is assigned to but never used
Review of attachment 324702 [details] [review]: looks good, thanks
thanks for the quick reviews! also pushing to 3.20, hope that's okay Attachment 324702 [details] pushed as b3f897b - test_gerror_novalue: Don't assign the error to a variable