After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764165 - test_gerror_novalue: Don't define an error - the test doesn't use one
test_gerror_novalue: Don't define an error - the test doesn't use one
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-24 18:07 UTC by Iain Lane
Modified: 2016-03-24 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test_gerror_novalue: Don't define an error - the test doesn't use one (1010 bytes, patch)
2016-03-24 18:07 UTC, Iain Lane
needs-work Details | Review
test_gerror_novalue: Don't assign the error to a variable (1.10 KB, patch)
2016-03-24 18:20 UTC, Iain Lane
committed Details | Review

Description Iain Lane 2016-03-24 18:07:37 UTC
Otherwise the build fails with:

  CHECK  Pyflakes examples gi tests pygtkcompat
  tests/test_gobject.py:689: local variable 'error' is assigned to but never used
Comment 1 Iain Lane 2016-03-24 18:07:41 UTC
Created attachment 324697 [details] [review]
test_gerror_novalue: Don't define an error - the test doesn't use one
Comment 2 Christoph Reiter (lazka) 2016-03-24 18:10:46 UTC
Review of attachment 324697 [details] [review]:

That line still tests that construction doesn't fail, so only the assignment to "error" should be removed.
Comment 3 Christoph Reiter (lazka) 2016-03-24 18:11:57 UTC
Somewhat related: bug 764087
Comment 4 Iain Lane 2016-03-24 18:20:39 UTC
Created attachment 324702 [details] [review]
test_gerror_novalue: Don't assign the error to a variable

Otherwise the build fails with:

  CHECK  Pyflakes examples gi tests pygtkcompat
  tests/test_gobject.py:689: local variable 'error' is assigned to but never used
Comment 5 Christoph Reiter (lazka) 2016-03-24 18:22:13 UTC
Review of attachment 324702 [details] [review]:

looks good, thanks
Comment 6 Iain Lane 2016-03-24 18:31:34 UTC
thanks for the quick reviews! also pushing to 3.20, hope that's okay

Attachment 324702 [details] pushed as b3f897b - test_gerror_novalue: Don't assign the error to a variable