GNOME Bugzilla – Bug 764087
[PATCH] Move pep8/pyflakes tests from 'make check' to 'make check.quality'
Last modified: 2016-12-23 09:10:38 UTC
Created attachment 324598 [details] [review] Move pep8/pyflakes tests from 'make check' to 'make check.quality' A proposal, feedback welcome.
Hi Christoph, I'm curious if this is a reaction to problems like bug 764165? What do you think about including pyflakes and pep8 as part of the pygobject source tree similar to what gobject-introspetion does [1] ? This would also avoid the occasional pyflakes/pep8 failures which come when newer versions of these tools come along. I believe bug 764165 was probably an error on my part because I had been developing on a new machine without these tools installed. It looks like the test suite happily passes in this case, only printing a warning which is quickly lost in the test output. [1] https://git.gnome.org/browse/gobject-introspection/tree/misc
(In reply to Simon Feltman from comment #1) > Hi Christoph, > > I'm curious if this is a reaction to problems like bug 764165? Yeah, but had it on my mind before. I'm mostly concerned that distributions or people trying to provide patches fail to run the test suite because of this. Imho doing a check.quality+fix run once in a while is a good compromise. Or if during review obvious errors are visible ask for a check.quality run. > What do you think about including pyflakes and pep8 as part of the pygobject > source tree similar to what gobject-introspetion does [1] ? This would also > avoid the occasional pyflakes/pep8 failures which come when newer versions > of these tools come along. Sounds like a good idea as well. Another thing I find annoying is that pep8/pyflakes takes a long time, especially if only one test is executed... which would also be addressed with the attached patch here.
Review of attachment 324598 [details] [review]: Ok, lets do this.
Thanks