After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763179 - Modal dialogs break the map view mouse events
Modal dialogs break the map view mouse events
Status: RESOLVED OBSOLETE
Product: gnome-maps
Classification: Applications
Component: map view
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
: 763469 (view as bug list)
Depends on: 758350
Blocks:
 
 
Reported: 2016-03-06 18:11 UTC by Marius Stanciu
Modified: 2018-03-26 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[clutter-backend] Modal dialogs break the mapView mouse events (1.04 KB, patch)
2016-03-06 18:15 UTC, Marius Stanciu
none Details | Review

Description Marius Stanciu 2016-03-06 18:11:12 UTC
Hi, new around here!

Popping any modal dialog ( then closing it ) while keeping the mouse inside the main window makes the map view ignore all the mouse events ( such as clicks, drags, right-click context menus etc ).

Here's a gif depicting it on my (Fedora) system:
https://media.giphy.com/media/3o7abrnkUoKlHl6wuY/giphy.gif

After a lot of trial and error and research I figured out it was a Clutter bug ( might report it later on their bug thingie), specifically, the interaction between Clutter and Gdk.

I have found a workaround/fix by changing the clutter's windowing backend to X11
(the default is Gdk ) but I am not really sure about the implications of such a change ( although everything seems to be fine on my machine ).

I will attach a patch containing my hotfix.
Comment 1 Marius Stanciu 2016-03-06 18:15:28 UTC
Created attachment 323203 [details] [review]
[clutter-backend] Modal dialogs break the mapView mouse events
Comment 2 Jonas Danielsson 2016-03-06 19:21:22 UTC
Thx! This is known! I had a similar fix commited but reverted it becouse it will break wayland.

*** This bug has been marked as a duplicate of bug 758350 ***
Comment 3 Marius Stanciu 2016-03-07 11:08:06 UTC
Had a look at the bug you mentioned and I can't see how they are duplicates. That bug is about map view not redrawing properly after popovers so visual artifacts remain. This one is about map view freezing after popping the "About" dialog ( and other Modal dialogs ), more specifically not responding to mouse events. Coincidentally, the proposed fix seems to solve both of them. 
Hope i'm not missing something!
Comment 4 Jonas Danielsson 2016-03-07 11:37:35 UTC
(In reply to Marius Stanciu from comment #3)
> Had a look at the bug you mentioned and I can't see how they are duplicates.
> That bug is about map view not redrawing properly after popovers so visual
> artifacts remain. This one is about map view freezing after popping the
> "About" dialog ( and other Modal dialogs ), more specifically not responding
> to mouse events. Coincidentally, the proposed fix seems to solve both of
> them. 
> Hope i'm not missing something!

Both are caused by running the GDK backend of clutter. The fix will make wayland crash since x11 is not a possible backend there. Re-opening but linking them.

Either fixes needs to go into the GDK backend or we need a way of setting X11 backend on X11 but not on wayland.
Comment 5 Nayan Deshmukh 2016-03-10 18:56:41 UTC
*** Bug 763469 has been marked as a duplicate of this bug. ***
Comment 6 Marius Stanciu 2016-03-14 11:47:40 UTC
The fix at https://bugzilla.gnome.org/show_bug.cgi?id=763469 practically made the dialog unmodal. ( look: http://s17.postimg.org/q4a3a01gd/modal.png )

Should I apply the same fix/workaround to the other dialogs that freeze the mapView? ( About and Shortcuts dialogs )

This should only be a temporary fix until Clutter's GDK back-end is fixed. ( that's the real cause of both this bug and bug 763469 )
Comment 7 GNOME Infrastructure Team 2018-03-26 13:11:15 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-maps/issues/55.