After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758350 - MapView not refreshing properly leaving bits of popovers around
MapView not refreshing properly leaving bits of popovers around
Status: RESOLVED OBSOLETE
Product: gnome-maps
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks: 763179
 
 
Reported: 2015-11-19 16:29 UTC by Andreas Nilsson
Modified: 2018-03-26 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (442.36 KB, image/jpeg)
2015-11-19 16:30 UTC, Andreas Nilsson
  Details
Cast of mapbubble graphics bug (1.38 MB, video/webm)
2016-02-03 19:44 UTC, Jonas Danielsson
  Details
Cast of mapbubble graphics bug (510.26 KB, video/webm)
2016-02-03 19:47 UTC, Jonas Danielsson
  Details
application: Prefer X11 and Wayland backends over GDK (1.09 KB, patch)
2016-02-09 20:32 UTC, Jonas Danielsson
committed Details | Review

Description Andreas Nilsson 2015-11-19 16:29:05 UTC
it doesn't go away
Comment 1 Andreas Nilsson 2015-11-19 16:30:07 UTC
Created attachment 315902 [details]
screenshot
Comment 2 Damián Nohales 2015-12-06 23:46:22 UTC
Thanks!

Yeah, I was able to reproduce this for a long time. But is not related to the current position bubble, more like the map view is not refreshing when the bubble disappears. Same happens for map bubbles, layers selection bubble and search results bubble, where clicking the map is not enough to make the bubble disappear, but you need to pan or zoom it in/out.

I'm still looking at it.
Comment 3 Damián Nohales 2015-12-07 00:06:02 UTC
Ok, so calling queue_redraw in the view right when we have popovers visible and stuck fixes the problem.
Comment 4 Jonas Danielsson 2015-12-07 06:27:04 UTC
(In reply to Damián Nohales from comment #3)
> Ok, so calling queue_redraw in the view right when we have popovers visible
> and stuck fixes the problem.

(o/

Now the problem becomes, is this an libchamplain/clutter/clutter-gtk or gtk+ problem or are we doing something wrong?

Because it seems like this started happening sometime, but without changes to our code.
Comment 5 Damián Nohales 2015-12-07 08:52:56 UTC
(In reply to Jonas Danielsson from comment #4)
> Now the problem becomes, is this an libchamplain/clutter/clutter-gtk or gtk+
> problem or are we doing something wrong?
> 
> Because it seems like this started happening sometime, but without changes
> to our code.

I made a little Champlain based program outside of GNOME Maps with a popover in the header bar and a button inside the map view (using an overlay), I can bug the popover there and also the button (when I try to hide it, it doesn't hide until I pan, zoom or manually call queue_redraw).

I tried to do the same but with a simple Clutter actor with only a background color but couldn't bug the Gtk+ controls.

So not sure, I'm still looking at it. If we are sure that this wasn't happening before we should at least bisect these components.
Comment 6 Jonas Danielsson 2015-12-07 08:59:38 UTC
(In reply to Damián Nohales from comment #5)
> (In reply to Jonas Danielsson from comment #4)
> > Now the problem becomes, is this an libchamplain/clutter/clutter-gtk or gtk+
> > problem or are we doing something wrong?
> > 
> > Because it seems like this started happening sometime, but without changes
> > to our code.
> 
> I made a little Champlain based program outside of GNOME Maps with a popover
> in the header bar and a button inside the map view (using an overlay), I can
> bug the popover there and also the button (when I try to hide it, it doesn't
> hide until I pan, zoom or manually call queue_redraw).
> 
> I tried to do the same but with a simple Clutter actor with only a
> background color but couldn't bug the Gtk+ controls.
> 
> So not sure, I'm still looking at it. If we are sure that this wasn't
> happening before we should at least bisect these components.

Thanks for looking in to this!

So maybe a first step would be to bisect champlain? Try a version some time ago and see if it is still there?
Comment 7 Damián Nohales 2015-12-07 16:44:18 UTC
Since my latest rawhide update and reboot, I can no longer reproduce this. I don't know if that's bad or good :P
Comment 8 Jonas Danielsson 2016-02-03 19:44:18 UTC
Created attachment 320392 [details]
Cast of mapbubble graphics bug
Comment 9 Jonas Danielsson 2016-02-03 19:47:59 UTC
Created attachment 320393 [details]
Cast of mapbubble graphics bug
Comment 10 Jonas Danielsson 2016-02-04 09:47:34 UTC
Comment from GTK+ maintainer:

9:41 PM <•Company> jonasdn: [it's] your bug
9:42 PM <•Company> jonasdn: it's called "someone is using clutter-gtk"
9:43 PM <•Company> jonasdn: and it could be anything, gtk, clutter, clutter-gtk or something else entirely :/
Comment 11 Jonas Danielsson 2016-02-09 19:42:20 UTC
Forcing the x11 backend of clutter-gtk seem to help, maybe. But then can we manage wayland?
Comment 12 Jonas Danielsson 2016-02-09 20:32:18 UTC
Created attachment 320752 [details] [review]
application: Prefer X11 and Wayland backends over GDK

This seems to play better with clutter-gtk and makes
a bug where bits of popovers where left on map dissapear.
Comment 13 Jonas Danielsson 2016-02-09 20:32:36 UTC
Does this work for you Andreas?
Comment 14 Jonas Danielsson 2016-02-11 17:22:27 UTC
Attachment 320752 [details] pushed as 7e5678d - application: Prefer X11 and Wayland backends over GDK
Comment 15 Gatlin Johnson 2016-02-11 21:21:46 UTC
When I build commit 7e5678d and run on Arch Linux / GNOME 3.18.2 I get the following error when I try to run it:

    (gnome-maps:8833): Clutter-ERROR **: Unsupported Clutter backend:   'x11,wayland,*'
Trace/breakpoint trap (core dumped)
Comment 16 Hashem Nasarat 2016-02-11 22:15:49 UTC
Gatlin, are you using jhbuild? Did you try jhbuild build gnome-maps to rebuild all the dependencies of gnome-maps? It's working fine for me with an up-to-date build of the modules.
Comment 17 Jonas Danielsson 2016-02-12 06:44:20 UTC
(In reply to Gatlin Johnson from comment #15)
> When I build commit 7e5678d and run on Arch Linux / GNOME 3.18.2 I get the
> following error when I try to run it:
> 
>     (gnome-maps:8833): Clutter-ERROR **: Unsupported Clutter backend:  
> 'x11,wayland,*'
> Trace/breakpoint trap (core dumped)

hmm, yeah, this is since Clutter 1.26... Which has not been released. I didn't realize it was that recent. We might want to make Maps depend on that version in configure.ac to make this more clear.
Comment 18 Jonas Danielsson 2016-02-12 06:49:39 UTC
(In reply to Jonas Danielsson from comment #17)
> (In reply to Gatlin Johnson from comment #15)
> > When I build commit 7e5678d and run on Arch Linux / GNOME 3.18.2 I get the
> > following error when I try to run it:
> > 
> >     (gnome-maps:8833): Clutter-ERROR **: Unsupported Clutter backend:  
> > 'x11,wayland,*'
> > Trace/breakpoint trap (core dumped)
> 
> hmm, yeah, this is since Clutter 1.26... Which has not been released. I
> didn't realize it was that recent. We might want to make Maps depend on that
> version in configure.ac to make this more clear.

To clarify, what is new is writing the backend order as a comma-separated string. We could re-write this to avoid depending on a that recent clutter.

Would be some logic like:

if (Clutter.check_windowing_backend('x11'))
    Clutter.set_windowing_backend('x11');
else if (Clutter.check...
Comment 19 Jonas Danielsson 2016-03-06 19:21:22 UTC
*** Bug 763179 has been marked as a duplicate of this bug. ***
Comment 20 Jonas Danielsson 2016-03-06 19:22:51 UTC
Reopening since this fix breaks wayland.
Comment 21 GNOME Infrastructure Team 2018-03-26 13:03:11 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-maps/issues/31.