After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762881 - No indication that CAPS LOCK is pressed
No indication that CAPS LOCK is pressed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
: 757082 775100 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-02-29 17:42 UTC by Andreas Nilsson
Modified: 2019-01-29 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch working on wayland but breaking X11 (3.26 KB, patch)
2018-11-24 01:25 UTC, Benjamin Berg
none Details | Review

Description Andreas Nilsson 2016-02-29 17:42:33 UTC
Today when I booted my Fedora Rawhide system I couldn't log in for some reason.
I kept typing my password over and over again, but it didn't work for some reason.

Then after a while I tested to press the caps lock key. It didn't show the regular caps lock-warning, but I had nothing else left to try. To my surprise, that did the trick!

So it seems the login screen is unable to show the warning. This might be specific to running it on top of Wayland.
Comment 1 Ray Strode [halfline] 2016-02-29 17:43:57 UTC
So this is because of this code I think:

static void•
keymap_state_changed (GdkKeymap *keymap,•
                      gpointer   user_data)•
{•
  StEntry *entry = ST_ENTRY (user_data);•
  StEntryPrivate *priv = ST_ENTRY_PRIV (entry);•
•
  if (clutter_text_get_password_char (CLUTTER_TEXT (priv->entry)) != 0)•
    {•
      if (gdk_keymap_get_caps_lock_state (keymap))•
        show_capslock_feedback (entry);•
      else•
        remove_capslock_feedback (entry);•
    }•
}•


We're asking gdk for capslock state but of course gnome-shell initializes gdk with the X11 backend.
Comment 2 Florian Müllner 2016-11-28 15:31:16 UTC
*** Bug 775100 has been marked as a duplicate of this bug. ***
Comment 3 Laurent Bigonville 2016-11-30 14:13:46 UTC
Any news about this one?

I'm not sure I understand your last comment Ray
Comment 4 André Klapper 2017-08-12 22:57:38 UTC
*** Bug 757082 has been marked as a duplicate of this bug. ***
Comment 5 Benjamin Berg 2018-11-24 01:25:46 UTC
Created attachment 374162 [details] [review]
Patch working on wayland but breaking X11

So, someone asked in person about this, and I figured I would take a look. Out came the above patch. The patch seems to work fine on wayland, but breaks on X11.

Now, I believe X11 breaks because of the patch from
  https://bugzilla.gnome.org/show_bug.cgi?id=690664
which, to be honest, seems rather odd to me. I have no idea how an application should check the caps lock state with the patch in, the information is generally masked out. And such masking does not seem to happen on wayland.
Comment 6 Carlos Garnacho 2019-01-29 16:08:57 UTC
This is now fixed on mutter/gnome-shell master with https://gitlab.gnome.org/GNOME/gnome-shell/commit/95a31b0c319ee86d5b64d3115c62dcd324bd7138