GNOME Bugzilla – Bug 762491
PlaceBubble needs small design fixups
Last modified: 2017-06-22 10:37:36 UTC
See patch. After image: http://i.imgur.com/Srlrpx6.jpg
Created attachment 321897 [details] [review] PlaceBubble: Add tooltip-text to edit button All the other buttons in the popover have tooltip-text.
Created attachment 321898 [details] [review] PlaceBubble: Show website url instead of "website" Showing the actual url provides useful information.
Review of attachment 321897 [details] [review]: Thanks! ::: data/ui/place-bubble.ui @@ +46,3 @@ <property name="valign">GTK_ALIGN_START</property> <property name="halign">GTK_ALIGN_CENTER</property> + <property name="tooltip-text" translatable="yes">Edit information</property> I think this should be "Edit on OpenStreetMap" since that is the title of the osm-edit-dialog, and maybe we don't have to announce the string then? If we want to add this in 3.20?
Review of attachment 321898 [details] [review]: Thanks! This is a free-text input from OSM right? Do we need to take some pre-cautions? Should we ellipsize if it is too long?
Created attachment 322157 [details] [review] PlaceBubble: Add tooltip-text to edit button All the other buttons in the popover have tooltip-text.
Created attachment 322158 [details] [review] PlaceBubble: Show website url instead of "website" Showing the actual url provides useful information.
Screenshot of a long url http://i.imgur.com/RvkCkFp.png
Review of attachment 322157 [details] [review]: Thanks!
Review of attachment 322158 [details] [review]: Thanks! Code looks fine. Andreas what do you think of this?
Before: http://i.imgur.com/pZsA9Vl.png After: http://i.imgur.com/M9zS2xF.png
My first reaction was that the alignment of the labels are all off, but that's probably another bug. Since it's the only entry without a label to it, it looks slightly out of place. I think something like "Website: https://www.gnome.org" Another thing to consider would be to drop the protocol part of the address, and make it just "Website: www.gnome.org" How are very long addresses, such as http://www.thelongestdomainnameintheworldandthensomeandthensomemoreandmore.com/ handled? Will it expand the width of the bubble, or truncate at some point?
Created attachment 352905 [details] [review] PlaceBubble: Use the title as a hyperlink I thought the website link was unnecessarily hidden, so I tried using the place title as a hyperlink.
Created attachment 352906 [details] Screenshot showing place title as link
(In reply to Robert Ancell from comment #13) > Created attachment 352906 [details] > Screenshot showing place title as link I think it looks pretty nice! I would wait for some additional (design) opinion before proceeding though!
Placing it in the header indeed does it more visible, but it still has the issue, just like the "Website" label does, it won't tell you where you'll end up if you click the url. So I like Hashem's approach a bit better. Both Google Maps and Apple Maps will show you the domain name in their UIs. Google Maps: https://www.thurrott.com/wp-content/uploads/2017/02/paris-hero-1024x576.jpg Apple Maps: http://media.idownloadblog.com/wp-content/uploads/2015/06/Google-Maps-desktop-send-to-mobile-device.png
Does that matter if you don't know the full address? Most hyperlinks in websites don't show you where they go unless you look at the bottom of the browser. The link will be shown in the browser once you follow the link.
> I thought the website link was unnecessarily hidden, so I tried using the place title as a hyperlink. I've been thinking more about this, and I feel more and more that hiding the web link by default is the root of the problem here. It's a very popular tag in the OSM database, and it deserves to be seen. Then comes the question of how to handle that, what to hide instead. In my opinion, the postal address, and the opening hours of other days than the current are good candidates for that. https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/maps/popup-bubble.png This requires Maps to know what time it currently is. I've filed bug #783664 about that.
I'll keep trying :) The point of a hyperlink is to hide the mechanism (the URL) behind the context (i.e. the POI name). By making a separate element for the link we're exposing this gory detail and losing some of the context. If you abbreviate the URL, then it gets misleading as the link is *almost* the same as what you read (see below for an example of where this is bad). IMHO using a web address as the text of a hyperlink is a bad design anti-pattern. I would suggest the primary method of getting more information about a POI is to visit the website. By putting the link in the title it's very fast to click on a POI and click to the website. Every line makes the popup into a wall of text, and using the title as a hyperlink solves this. (The Google design is hard to read to me). There are lots of lousy websites out there, you get things like: - http://www.generic-site.com/name-of-place. If you abbreviate this like Google has you won't differentiate between "name-of-place" and "name-of-other-place". - http://www.wereallydontknow.how/tothinkof/a/memorableaddresssowechosesomethingoverlylong.html - This will either truncate badly or make the popup really wide. If we're worried about security of the link (you don't know what you get to until you click on it) then we're more paranoid than the browser developers. Most of the web is made up of links like this. With a mouse you can hover for more information on the link (we can do this too) but in a touch display you never know until you click on it. I think if it's safe for the web then it's safe for us.
(In reply to Robert Ancell from comment #18) > I'll keep trying :) > I would suggest the primary method of getting more information about a POI > is to visit the website. By putting the link in the title it's very fast to > click on a POI and click to the website. > > Every line makes the popup into a wall of text, and using the title as a > hyperlink solves this. (The Google design is hard to read to me). These are good arguments. While I'm worried about the discoverability of this, it's easy to test in a usability test (I want to conduct one on a general redesign of the bubbles matching the mockup above, so we can test that then). So yeah, let's get this one in.
So to confirm, Andreas and Marcus you're both OK to commit my patch as-is?
(In reply to Robert Ancell from comment #20) > So to confirm, Andreas and Marcus you're both OK to commit my patch as-is? Yes.
Review of attachment 352905 [details] [review]: LGTM
Attachment 322157 [details] pushed as 5a3f284 - PlaceBubble: Add tooltip-text to edit button Attachment 352905 [details] pushed as 120c3b4 - PlaceBubble: Use the title as a hyperlink