After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762171 - soundtouch plugin is not shipped
soundtouch plugin is not shipped
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.7.1
Other Windows
: Normal normal
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-17 05:29 UTC by George Yunaev
Modified: 2016-02-19 07:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Packaging libgstsoundtouch into -bad package (661 bytes, patch)
2016-02-19 00:29 UTC, George Yunaev
committed Details | Review

Description George Yunaev 2016-02-17 05:29:05 UTC
gstlibsoundtouch.dll is not being built anymore as part of the http://gstreamer.freedesktop.org/data/pkg/windows/ build, at least for versions 1.6.2, 1.6.3 and 1.7.1. 

However since libSoundTouch.lib is present in the package, there's a possibility it could be built, is that right?
Comment 1 Sebastian Dröge (slomo) 2016-02-17 07:22:11 UTC
Did you select installation of all plugins or just the default? The file should be C:\GStreamer\1.0\x86_64\lib\gstreamer-1.0\libgstsoundtouch.dll (and the same for x86), not gstlibsoundtouch.dll.
Comment 2 George Yunaev 2016-02-17 07:40:55 UTC
I chose 'Complete install', so everything should be installed. I also tried again with 'Custom' install and chose everything, no luck.

It is very easy to see using wine:

azu:~/gst> msiexec /i gstreamer-1.0-x86_64-1.6.3.msi 

[... a lot of Wine output ... ]

azu:~/gst> find /home/tim/.wine/ -iname libgstsoundtouch.dll
azu:~/gst>

Same goes for gstreamer-1.0-x86-1.6.3.msi, so it is not just 64-bit.

Even more, one can run (on Windows only):

msiexec /a gstreamer-1.0-x86_64-1.6.3.msi /qb TARGETDIR=c:\temp\

this would unpack the archive into c:\temp - then you can see there is no libgstsoundtouch.dll.
Comment 3 Sebastian Dröge (slomo) 2016-02-17 07:46:29 UTC
This might be the same as bug #761112 then
Comment 4 George Yunaev 2016-02-17 07:50:45 UTC
Maybe the same packaging issue, or maybe a different one (I can't say if it is even is built, for example).

Would it be possible to also upload ZIP archives together with MSI files? It would make it much easier to check whether a specific file is present or missing.

And is there a nighty build which we could check and get this file? I spent last four hours trying to build this plugin from source, and doing so without rebuilding GStreamer as a whole seems to be a major issue.
Comment 5 Sebastian Dröge (slomo) 2016-02-17 07:55:57 UTC
It's not, winks is there but soundtouch not.
Comment 6 George Yunaev 2016-02-17 08:07:50 UTC
Would you guys please take a look then if it is still supported on Windows? I know Cygwin builds it, but Cygwin's a different animal...
Comment 7 Sebastian Dröge (slomo) 2016-02-17 08:38:29 UTC
I have it here in my own build, but it's indeed not in the .msi installers.
Comment 8 George Yunaev 2016-02-17 08:47:50 UTC
Great! Then hopefully it will make it there next release?
Comment 9 Sebastian Dröge (slomo) 2016-02-17 08:57:11 UTC
If someone finds the reason why it's not included in the .msi although it should, sure :)
Comment 10 George Yunaev 2016-02-17 09:52:57 UTC
Thank you Sebastian, will wait for this.

By the way, is there a script/repo/tool which would pull all the dependencies, compile them, and compile GStreamer on Windows, or you just have a prebuilt environment you use for builds?
Comment 11 Sebastian Dröge (slomo) 2016-02-17 09:57:30 UTC
We're using cerbero for that from https://cgit.freedesktop.org/gstreamer/cerbero/

See the README for the things you have to manually install, everything else it downloads and installs/compiles for you.
Comment 12 George Yunaev 2016-02-17 21:56:24 UTC
After spending two days trying to set up Cerbero and compile it, I gave up. It does not work with recent Mingw/Msys toolchain, failing to build gnutls due to too new gcc/too old glibc. So I'll wait for a new release then.
Comment 13 Sebastian Dröge (slomo) 2016-02-18 07:45:13 UTC
Can you file another bug about how cerbero failed for you? Let's get that fixed :)
Comment 14 George Yunaev 2016-02-18 08:17:39 UTC
Repeating the build now. It is unclear where it stores build logs, and whether the next build overwrites them or creates a new one, so now I'm running it under tee so I will have a copy of the log once it fails, and then create a bug.
Comment 15 George Yunaev 2016-02-19 00:29:01 UTC
Created attachment 321622 [details] [review]
Packaging libgstsoundtouch into -bad package

Apparently it was not packaged. Tested it, now it is there.
Comment 16 Sebastian Dröge (slomo) 2016-02-19 07:02:50 UTC
commit fe642e898580f6dfc5a74dc09e56fa8aa75da187
Author: George Yunaev <gyunaev@gmail.com>
Date:   Fri Feb 19 08:59:52 2016 +0200

    gst-plugins-bad: Ship the soundtouch plugin
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762171