GNOME Bugzilla – Bug 761276
connectionPopover: Reconnect does not do anything when already connected
Last modified: 2016-02-17 21:08:10 UTC
(In reply to Florian Müllner from comment #2, Bug 761057) > - "Reconnect" not doing anything when already connected is confusing. This > wasn't > an issue before as it was only used in the error case, but now should > either > make it do something (disconnect + reconnect) or disable it when it would > do nothing > (in any case it's a separate patch, I'm just mentioning it to not forget > it later) Opening a separate bug for this. I think making it do something (disconnect + reconnect) would be fine. to avoid a popover changing size, it would have to occupy the space there, and then I don't see much gain in making it insensitive.
I'll be working on this. Do we need to change the label? I thought the disconnect + reconnect could be transparent to the user.
(In reply to Isabella Ribeiro from comment #1) > Do we need to change the label? I don't think so - fwiw, hexchat(*) does have a "Reconnect" menu item that behaves like that, i.e. disconnect if necessary, then try to connect. (*) I know, not the greatest source of UI inspiration
Also, since bug 709984 landed: "Reconnect" doesn't do anything for account with no rooms either.
Created attachment 321287 [details] [review] connectionPopover: Reconnect does not do anything when connected When already connected, the reconnect button on popover does not do anything. To fix this issue, we changed the reconnect action which is now using the reconnect_async() from tp account to disconnect and connect in every call. But this solution doesn't apply when the account is offline, the proposed solution for this in a future implementation is to connect to all accounts on startup.
Review of attachment 321287 [details] [review]: Ugh sorry, completely missed that there was a patch here - looks good!
Attachment 321287 [details] pushed as 51bff04 - connectionPopover: Reconnect does not do anything when connected