GNOME Bugzilla – Bug 709984
show connections without active channels
Last modified: 2016-01-29 15:36:35 UTC
currently, if you are connected to a network but not active on any channel, the left panel doesn't show anything. perhaps we should show it, just like xchat does.
The real issue here is that, if you add a network, you will generally then want to populate it with channels. There are a few ways to do this: * Add a way to specify multiple channels into the add network dialog. * Have an "add multiple channels" item under the network in the sidebar when it is empty. I think that the former is probably better.
Created attachment 319978 [details] [review] polari-room: Move room_compare() into JS We will soon add placeholder rows without an associated room to the roomList, so do the row sorting directly in JS instead of using a PolariRoom method.
Created attachment 319979 [details] [review] roomList: Include accounts with no rooms We want to remove the old connections dialog in favor of managing accounts directly from the room list. As we still want users to be able to manage accounts that don't have any joined rooms, we need to stop excluding them from the room list.
Created attachment 319980 [details] [review] roomList: Sort accounts with no rooms last We now include inactive accounts in the list so the user can manage them, but they are less interesting than accounts with open conversations - make the sort order reflect that.
Review of attachment 319978 [details] [review]: looks good to me.
Review of attachment 319979 [details] [review]: looks good to me. I have some comments/suggestions but nothing blocking. ::: src/roomList.js @@ +446,3 @@ + + let placeholder = new Gtk.ListBoxRow({ selectable: false, + activatable: false }); we might want to consider making the placeholder visible simply stating "no rooms" in italic or so, what do you think? in any case I think this is a good starting point and the suggestion could be a separate patch/bug. @@ +489,3 @@ + + _updatePlaceholderVisibility: function(account) { + if (!account.enabled) { I wonder if this check is necessary once we remove the Connections dialog and there's no way to "disable" accounts. but i guess that's something to do in a separate bug/patch.
Review of attachment 319980 [details] [review]: looks fine by me.
Created attachment 320019 [details] Visible placeholder (In reply to Bastian Ilsø from comment #6) > we might want to consider making the placeholder visible simply stating "no > rooms" in italic or so, what do you think? Dunno, might be a bit much for something that's mostly uninteresting ...
(In reply to Bastian Ilsø from comment #6) > + _updatePlaceholderVisibility: function(account) { > + if (!account.enabled) { > > I wonder if this check is necessary once we remove the Connections dialog > and there's no way to "disable" accounts. Not very user friendly, but: gdbus call --session --dest org.freedesktop.Telepathy.AccountManager --object-path /org/freedesktop/Telepathy/Account/idle/irc/fmuellner4 --method org.freedesktop.DBus.Properties.Set 'org.freedesktop.Telepathy.Account' 'Enabled' '<false>' (or more friendly via empathy, kopete or (for now) the "Online Accounts" panel)
Attachment 319978 [details] pushed as 5a2b488 - polari-room: Move room_compare() into JS Attachment 319979 [details] pushed as 36ed1c9 - roomList: Include accounts with no rooms Attachment 319980 [details] pushed as 8a28956 - roomList: Sort accounts with no rooms last