After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761019 - Use the correct OAuthProxy object to check for the access token
Use the correct OAuthProxy object to check for the access token
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-23 11:30 UTC by Marcus Lundblad
Modified: 2016-01-23 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
osmEdit: Use the call proxy when checking the OAuth access token (1.41 KB, patch)
2016-01-23 11:30 UTC, Marcus Lundblad 		committed Details | Review

Description Marcus Lundblad 2016-01-23 11:30:05 UTC 
Since the fix in https://bugzilla.gnome.org/show_bug.cgi?id=759464
we can not check the proxy used for sign-in, instead we should check the call
proxy to determine if the initial fetch from the keyring should be performed.
Comment 1 Marcus Lundblad 2016-01-23 11:30:48 UTC 
Created attachment 319584 [details] [review]
osmEdit: Use the call proxy when checking the OAuth access token

We can't rely on the sign-in proxy being availble to check for the
OAuth access token when trying to upload a changeset, since the
changes in https://bugzilla.gnome.org/show_bug.cgi?id=759464
since that proxy object will only be available right after a sign-in
operation now.
Instead check the call proxy, which is also updated on successfull
sign-in and in the keyring lookup callback.
Comment 2 Marcus Lundblad 2016-01-23 16:11:08 UTC 
Attachment 319584 [details] pushed as c1f058e - osmEdit: Use the call proxy when checking the OAuth access token