GNOME Bugzilla – Bug 759464
osm login box is unforgiving
Last modified: 2016-01-30 11:17:05 UTC
It seems there is something very unforgiving with the login dialog. 1. Open the dialog and try to log in. 2. Get the password wrong. 3. It asks you to try again, but it will actually not even accept the correct password this time around. If you get the password right the first time, it works as it should and you're allowed to log in.
Hmm, at first I couldn't seem to reproduce it. But now I could. Luckily, I found a solution :-) Patch coming up.
Created attachment 317605 [details] [review] osmEdit: Don't re-use OAuth proxy used for signing in It seems running request_token_async a second time on an OAuthProxy instance doesn't work well. So, instead create a new proxy each time the login process is being run.
Review of attachment 317605 [details] [review]: Thanks for the fix! ::: src/osmConnection.js @@ -24,3 @@ -const Utils = imports.utils; - Utils disappeared, I hope it was meant to?
(In reply to Jonas Danielsson from comment #3) > Review of attachment 317605 [details] [review] [review]: > > Thanks for the fix! > > ::: src/osmConnection.js > @@ -24,3 @@ > > -const Utils = imports.utils; > - > > Utils disappeared, I hope it was meant to? Yes, actually Utils wasn't used, so I axed at while at it :-)
Review of attachment 317605 [details] [review]: Pushed,,, right?