After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760527 - Use GtkPopover for "view-menu" and "action-menu"
Use GtkPopover for "view-menu" and "action-menu"
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-12 13:53 UTC by Felipe Borges
Modified: 2016-01-31 11:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: use popover for view-menu and action-menu (921 bytes, patch)
2016-01-12 13:54 UTC, Felipe Borges 		none Details | Review
shell: use popover for view-menu and action-menu (1.55 KB, patch)
2016-01-14 13:13 UTC, Felipe Borges 		committed Details | Review

Description Felipe Borges 2016-01-12 13:53:46 UTC 
Since we are already using GtkPopover for the "zoom-menu", why not use GtkPopover for "view-menu" and "action-menu" too?

GtkMenuButton already goes for a popover by default. Currently, we are using "gtk_menu_button_set_use_popover (GTK_MENU_BUTTON (button), FALSE);" while constructing these menus. Is there a reason for that?
Comment 1 Felipe Borges 2016-01-12 13:54:08 UTC 
Created attachment 318870 [details] [review]
shell: use popover for view-menu and action-menu
Comment 2 Germán Poo-Caamaño 2016-01-14 13:01:52 UTC 
Review of attachment 318870 [details] [review]:

::: shell/ev-toolbar.c
@@ -136,2 @@
         button = gtk_menu_button_new ();
-        gtk_menu_button_set_use_popover (GTK_MENU_BUTTON (button), FALSE);

Should not we also call gtk_popover_set_position()? See Bug 756976
Comment 3 Felipe Borges 2016-01-14 13:13:59 UTC 
Created attachment 319008 [details] [review]
shell: use popover for view-menu and action-menu
Comment 4 Carlos Garcia Campos 2016-01-31 09:30:59 UTC 
Comment on attachment 319008 [details] [review]
shell: use popover for view-menu and action-menu

Ok, I don't see why not :-) Thanks.
Comment 5 Felipe Borges 2016-01-31 11:28:06 UTC 
Attachment 319008 [details] pushed as cb3d4b2 - shell: use popover for view-menu and action-menu