After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756976 - GtkPopover is misplaced when attached to a GtkEntry in a GtkHeaderBar
GtkPopover is misplaced when attached to a GtkEntry in a GtkHeaderBar
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.18.x
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 748513 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-10-22 16:16 UTC by Christian Stadelmann
Modified: 2015-10-22 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell,plugin: Set position of GtkPopover. Fixes 756976 (2.06 KB, patch)
2015-10-22 17:42 UTC, Germán Poo-Caamaño 		committed Details | Review

Description Christian Stadelmann 2015-10-22 16:16:00 UTC 
Steps to reproduce:
1. Open evince, open a document
2. find the EvZoomAction widget containing a GtkEntry (in GtkHeaderBar). press the arrow button.

What happens:
A GtkPopover opens above the button. It is invisible and unreachable if evince is maximized.

What should happen:
A GtkPopover should open below the button (in most cases) depending on window position, size, orientation, …

Additional info:
I only tested on wayland, can't test on X right now.

Affected software versions:
Gtk 3.18.2
Evince 3.18.0
Fedora 23 with updates-testing enabled
Comment 1 Matthias Clasen 2015-10-22 16:43:16 UTC 
gtk does what it is told here. The default for GtkPopover::position is GTK_POS_TOP. Which may be an unfortunate choice, but it is too late to change it now. 

Evince needs to call gtk_popover_set_position (popover, GTK_POSITION_BOTTOM);
Comment 2 Germán Poo-Caamaño 2015-10-22 17:42:51 UTC 
Created attachment 313885 [details] [review]
shell,plugin: Set position of GtkPopover. Fixes 756976
Comment 3 Carlos Garcia Campos 2015-10-22 17:55:14 UTC 
Comment on attachment 313885 [details] [review]
shell,plugin: Set position of GtkPopover. Fixes 756976

Push it to both branches, please. Thanks
Comment 4 Germán Poo-Caamaño 2015-10-22 18:15:05 UTC 
Review of attachment 313885 [details] [review]:

Pushed in both, master and gnome-3-18.
Comment 5 Germán Poo-Caamaño 2015-10-22 18:15:23 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.
Comment 6 Germán Poo-Caamaño 2015-10-22 18:17:13 UTC 
*** Bug 748513 has been marked as a duplicate of this bug. ***