After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758356 - loader is hard to see
loader is hard to see
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 651331 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-11-19 17:45 UTC by Andreas Nilsson
Modified: 2015-11-27 21:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (40.26 KB, image/png)
2015-11-19 17:45 UTC, Andreas Nilsson 		  Details
shell: Fix css style for ev-loading-message (739 bytes, patch)
2015-11-26 20:57 UTC, Germán Poo-Caamaño 		committed Details | Review
Screenshot of the ev-loading-message after the patch. (20.04 KB, image/png)
2015-11-26 20:59 UTC, Germán Poo-Caamaño 		  Details

Description Andreas Nilsson 2015-11-19 17:45:54 UTC 
Created attachment 315906 [details]
screenshot

I get a white loader text+spinner against a gray background.
That makes it very hard to see.
Comment 1 Germán Poo-Caamaño 2015-11-19 17:58:37 UTC 
Deja vu. I had seen this before, but I could not find the bug report.

Maybe I just I believe I did so :-)
Comment 2 Germán Poo-Caamaño 2015-11-26 19:45:18 UTC 
*** Bug 651331 has been marked as a duplicate of this bug. ***
Comment 3 Germán Poo-Caamaño 2015-11-26 20:57:57 UTC 
Created attachment 316345 [details] [review]
shell: Fix css style for ev-loading-message

The CSS for ev-loading-message makes reference to @info_bg_color and @info_fg_color.

I could not find its definition in gnome-themes-standard (maybe it was deprecated at some point). I applied @theme_bg_color and @theme_fg_color as they are used to paint the EvView.
Comment 4 Germán Poo-Caamaño 2015-11-26 20:59:11 UTC 
Created attachment 316346 [details]
Screenshot of the ev-loading-message after the patch.
Comment 5 Germán Poo-Caamaño 2015-11-26 21:26:13 UTC 
For additional information:

@info_ was removed because of Bug 704266

It was replaced by @infobar_ which later was removed because of Bug 727416
Which is similar to this one.

In short, this has been a regression since 2013.
Comment 6 Germán Poo-Caamaño 2015-11-27 21:59:26 UTC 
Review of attachment 316345 [details] [review]:

Thanks. I applied to both master and gnome-3-18 branch.
Comment 7 Germán Poo-Caamaño 2015-11-27 21:59:58 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.