GNOME Bugzilla – Bug 704266
infobar colors are jarring
Last modified: 2013-07-15 21:45:22 UTC
Currently, we color the background of GtkInfoBar differently depending on what type of "message" it is displaying. I think this is counterproductive. The colors are quite alarming and they don't really change how the user is supposed to react to these messages. In fact, it isn't clear the user will have any idea what "type" of message the bar is displaying or whether they should. It just makes the message harder to interpret and distracts from the text (the actual message). Really the only requirement for infobars is that they are easy to distinguish from other controls. Attached is a patch that uses the "question" blue for all infobar classes.
Created attachment 249211 [details] [review] Use the same color for infobars
Review of attachment 249211 [details] [review]: I never really liked all the various infobar colors, so I agree with the general idea here. One thing though is that the way the message type is set on the infobar is through a public API, and GTK docs explicitly mention the message type changing the background color: "GTK+ uses the message type to determine the background color of the message area." If it doesn't make sense for the infobar to change background color, I feel that should be reflected in the API as well (e.g. it should be deprecated) and the documentation, otherwise it can be confusing for developers if the default behavior didn't match the expectations given by GTK. ::: themes/Adwaita/gtk-3.0/gtk-widgets.css @@ -3876,3 @@ .error .button, .error .button:insensitive, -.error .button:active { Should keep .error .button:active among in the selectors.
Created attachment 249220 [details] [review] Use the same color for infobars
https://git.gnome.org/browse/gtk+/commit/?id=31a2cea4b1901a51c9d5e72d715db21de669ee47
Review of attachment 249220 [details] [review]: Looks good.