After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758280 - Drop deprecated style properties
Drop deprecated style properties
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-18 13:10 UTC by Matthias Clasen
Modified: 2015-11-26 03:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Drop deprecated style properties (938 bytes, patch)
2015-11-18 13:10 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2015-11-18 13:10:03 UTC 
These have no effect anymore, other than causing warnings.
Comment 1 Matthias Clasen 2015-11-18 13:10:07 UTC 
Created attachment 315821 [details] [review]
Drop deprecated style properties
Comment 2 Tristan Van Berkom 2015-11-25 10:42:06 UTC 
Review of attachment 315821 [details] [review]:

Sure we can go ahead and commit this,

The properties mentioned there were to force the close button which we shove into a notebook tab to be appropriately small, I'm not sure if Glade has regressed without the use of those style properties, possibly we need to accommodate with some custom CSS (as you mentioned in Bug 758294).

Note that this is the sole purpose of the custom close button so it can probably be replaced entirely with CSS, it was taken from gedit's custom close button which seems to also have been removed from gedit sources and replaced with something else.
Comment 3 Matthias Clasen 2015-11-26 03:23:26 UTC 
Attachment 315821 [details] pushed as 74e9509 - Drop deprecated style properties