After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758294 - ship your own css
ship your own css
Status: RESOLVED OBSOLETE
Product: glade
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-18 16:12 UTC by Matthias Clasen
Modified: 2018-03-26 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ship css for GladeDesignLayout (2.71 KB, patch)
2015-12-11 23:51 UTC, Matthias Clasen 		needs-work Details | Review

Description Matthias Clasen 2015-11-18 16:12:53 UTC 
Instead of hoping for the theme to come through with good colors for random style classes and states, I would suggest that glade should just ship a bit of CSS like this:

GladeDesignLayout {
  color: white;
  background: blue;
}

GladeDesignLayout:selected {
  color: white;
  background: red;
}

Of course, the drawing code in glade-design-layout.c will need some adjustments.
Comment 1 Matthias Clasen 2015-12-11 23:51:56 UTC 
Created attachment 317242 [details] [review]
Ship css for GladeDesignLayout

This makes the frames visible with GTK+ 3.19. Further improvements
are possible: Could load different CSS depending on color.
Comment 2 Tristan Van Berkom 2015-12-13 04:52:14 UTC 
Review of attachment 317242 [details] [review]:

Cool !

I tried it and it works here, but has one problem.

You have added the calls which load the CSS to main.c, but as this
is specific to the GladeDesignLayout/View... it would be better to
add this in the class initializer of GladeDesignLayout.

This is because Glade's main.c is only used for Glade's own frontend,
and so the CSS will not be used in other applications which embed Glade
unless it is done inside the gladeui library itself.
Comment 3 GNOME Infrastructure Team 2018-03-26 15:50:43 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glade/issues/221.