GNOME Bugzilla – Bug 757694
File renaming popover GtkEntry is too narrow - should be wider
Last modified: 2015-11-26 13:41:16 UTC
Similar to bug #754968 but in a different area: when renaming a file, the text entry widget is too narrow. It can barely fit 2-3 words in compact languages like English, so it's more problematic in French, German or Klingon. I like to be able to see a wider part of the string/sentence when correcting it, to reduce scrolling and have a "context". Horizontal space is cheap, it's not like our screens are 640x480 these days, so I think we can afford the text entry being ~2x wider than it is in 3.18.1.
Created attachment 315372 [details] [review] toolbar: fix persistent operation popover The popover was remaining persistent after you clicked outside of the popover. We were setting modal false and I guess that was messing up the gtk popover management.
Attachment 315372 [details] pushed as d23238f - toolbar: fix persistent operation popover
*** Bug 757435 has been marked as a duplicate of this bug. ***
whops, Bug 757435 is the actual that got fixed, not this one.
Created attachment 315376 [details] [review] files-view: adapt rename entry length We are having some problems given that the rename entry is kind of small for some file names, and that makes the rename popover vs inline renaming kind of a problem. For that, increase the default entry length and adapt for longer names with a MIN/MAX length. https://bugzilla.gnome.org/show_bug.cgi?id=757180
Attachment 315376 [details] pushed as bf09c8f - files-view: adapt rename entry length
Could you backport that (and maybe some of the other recent bugfixes) to the stable gnome-3-18 branch as well?
(In reply to Sebastien Bacher from comment #7) > Could you backport that (and maybe some of the other recent bugfixes) to the > stable gnome-3-18 branch as well? ugh, this was intended for 3.18, not sure how I failed to backport. I think all the other fixes that can be in 3.18 are there, what do you think is missing?
Sebastien, actually the fix is there https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-18&id=a5eff664b94e71e1128bc44f165c51f2a325f22e I remember I actually worked on the 3.18 and then cherry picked to master. The fixes will be available on 3.18.2
sorry seems like I looked to the history based on an outdated checkout, seems fine indeed, thanks!