GNOME Bugzilla – Bug 757401
[PATCHes] cookies-dialog.ui: Unbloat.
Last modified: 2015-11-01 16:08:12 UTC
Here are a few patches to unbloat the CookiesDialog’s class. They are quite similar to a similar set for the HistoryDialog’s (bug 757228) and one for the PasswordsDialog’s (bug 757344).
Created attachment 314524 [details] [review] cookies-dialog.ui: Manually unbloat.
Created attachment 314525 [details] [review] CookiesDialog: Use tree_selection.
Created attachment 314526 [details] [review] CookiesDialog: Kill a level of GtkBox.
Created attachment 314527 [details] [review] CookiesDialog: Call response_cb from UI file.
Created attachment 314528 [details] [review] CookiesDialog: Use GActions.
Created attachment 314529 [details] [review] CookiesDialog: Define keybindings in UI file.
Created attachment 314530 [details] [review] CookiesDialog: Visual refresh (GtkActionBar, GtkSearchBar).
Created attachment 314531 [details] [review] CookiesDialog: Kill a (now) unneeded level of GtkBox.
Thanks for working on this. I think you should fix bug #757230 as well; should be easy compared to the work you've already done. Bonus points if you want to take on bug #723237.
Review of attachment 314524 [details] [review]: ::: src/resources/cookies-dialog.ui @@ -61,3 @@ <property name="orientation">vertical</property> <property name="spacing">2</property> - <child internal-child="action_area"> Wow, it added an unused action area....
Review of attachment 314525 [details] [review]: Is this really worth it, to save one use of gtk_tree_view_get_selection? I guess it's good if more uses would be added in the future, and to parallel the other dialogs.
Review of attachment 314526 [details] [review]: Dialog still works
Review of attachment 314527 [details] [review]: ++
Review of attachment 314528 [details] [review]: ::: src/cookies-dialog.c @@ +450,3 @@ + { "forget-all", forget_all } + }; + GSimpleActionGroup *group; Again, I think a blank line here would be good.
Review of attachment 314529 [details] [review]: OK
Review of attachment 314530 [details] [review]: OK
Review of attachment 314531 [details] [review]: ::: src/resources/cookies-dialog.ui @@ +114,3 @@ + <property name="sensitive">False</property> + <property name="tooltip_text" translatable="yes">Delete the selected cookies</property> + <property name="label" translatable="yes">Remove</property> <!-- TODO conflicts with the image --> OK, you already spotted this