After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757119 - Music is broken in jhbuild
Music is broken in jhbuild
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on: 705069
Blocks:
 
 
Reported: 2015-10-26 02:40 UTC by Michael Catanzaro
Modified: 2015-12-02 11:32 UTC
See Also:
GNOME target: 3.20
GNOME version: ---


Attachments
Disable mpris in order to not depend on dbus-python from now (1.60 KB, patch)
2015-12-02 10:36 UTC, Felipe Borges
none Details | Review

Description Michael Catanzaro 2015-10-26 02:40:40 UTC
GNOME Music has been broken in jhbuild for evidently some time.

 * The gnome-music module depends on dbus-python, which is in gnome-world, so it's not included in gnome-apps. You have to move dbus-python to gnome-apps if you want to depend on it.
 * dbus-python is a python2 build that depends on pygobject-python2, whereas gnome-music depends on pygobject (python3 build), so it's implausible that it really depends on both modules. The right fix (if a dependency on a python3 build of dbus-python was intended) is to build dbus-python as a python3 module, add a dbus-python2 module for compatibility, and switch existing modules in gnome-world over to that. Or just let gnome-world remain broken; it doesn't matter.
* Also, pygobject-python2 has a dependency on unknown "py2cairo" module, but that doesn't matter much since this should not depend on pygobject-python2 anyway.
* Finally, the only recent problem is the upgrade to grilo-0.3. All other GNOME modules that depend on grilo required changes to switch from grilo-0.2 to grilo-0.3, so I assume Music does as well.

Because of the above, I removed Music from the official modulesets; it will appear in the list of modules removed from the next GNOME release. That's not good, but I'm not up for trying to fix all of the above myself. Please do revert https://git.gnome.org/browse/jhbuild/commit/?id=7bec1eaf41e7780c2cb54dfa9e90bbd59c0fed73 as soon as Music is buildable again.
Comment 1 Javier Jardón (IRC: jjardon) 2015-10-27 16:54:02 UTC
About the dbus-python issue, this has been reported already here: https://bugzilla.gnome.org/show_bug.cgi?id=705069
Comment 3 Felipe Borges 2015-12-02 10:36:33 UTC
The only component that uses dbus-python is mpris. We could just disable it from now, upgrade to grilo 0.3, and have Music back to the official modulesets.
Comment 4 Felipe Borges 2015-12-02 10:36:46 UTC
Created attachment 316651 [details] [review]
Disable mpris in order to not depend on dbus-python from now

We need to port from dbus-python to GDBus in the future, but for
now, to have Music back to the jhbuild official moduleset, we need
to disable it. See bgo#757119.
Comment 5 Bastien Nocera 2015-12-02 11:32:35 UTC
A(In reply to Michael Catanzaro from comment #0)
> GNOME Music has been broken in jhbuild for evidently some time.
> 
>  * The gnome-music module depends on dbus-python, which is in gnome-world,
> so it's not included in gnome-apps. You have to move dbus-python to
> gnome-apps if you want to depend on it.

gnome-music works fine without dbus-python installed.

>  * dbus-python is a python2 build that depends on pygobject-python2, whereas
> gnome-music depends on pygobject (python3 build), so it's implausible that
> it really depends on both modules. The right fix (if a dependency on a
> python3 build of dbus-python was intended) is to build dbus-python as a
> python3 module, add a dbus-python2 module for compatibility, and switch
> existing modules in gnome-world over to that. Or just let gnome-world remain
> broken; it doesn't matter.

Again, gnome-music seems to work fine without dbus-python installed.

> * Also, pygobject-python2 has a dependency on unknown "py2cairo" module, but
> that doesn't matter much since this should not depend on pygobject-python2
> anyway.

Irrelevant, as mentioned above.

> * Finally, the only recent problem is the upgrade to grilo-0.3. All other
> GNOME modules that depend on grilo required changes to switch from grilo-0.2
> to grilo-0.3, so I assume Music does as well.

Done in bug 758942.

> Because of the above, I removed Music from the official modulesets; it will
> appear in the list of modules removed from the next GNOME release. That's
> not good, but I'm not up for trying to fix all of the above myself. Please
> do revert
> https://git.gnome.org/browse/jhbuild/commit/
> ?id=7bec1eaf41e7780c2cb54dfa9e90bbd59c0fed73 as soon as Music is buildable
> again.

Done, thanks.



commit 48f30ea8e632a60d74092a2f91507ca76b42c791
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Dec 2 12:11:50 2015 +0100

    Revert "3.20: Drop gnome-music to gnome-world"
    
    But keep the dbus-python module off the required modules.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=757119#c0
    
    This reverts commit 7bec1eaf41e7780c2cb54dfa9e90bbd59c0fed73.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757119