After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705069 - Port from dbus-python to Gio GDBus API
Port from dbus-python to Gio GDBus API
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: High normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 759751 (view as bug list)
Depends on: 656330
Blocks: 757119
 
 
Reported: 2013-07-29 10:57 UTC by Javier Jardón (IRC: jjardon)
Modified: 2016-04-04 08:33 UTC
See Also:
GNOME target: 3.22
GNOME version: ---


Attachments
Port MPRIS to pydbus (31.97 KB, patch)
2016-03-16 22:01 UTC, Gaurav Narula
none Details | Review
Port MPRIS to Gio GDBUS API (31.90 KB, patch)
2016-03-18 17:26 UTC, Gaurav Narula
committed Details | Review
Handle an edge case in GetAll (1.18 KB, patch)
2016-03-18 20:06 UTC, Gaurav Narula
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2013-07-29 10:57:40 UTC
dbus-python is deprecated for years and not part of GNOME anymore

https://developer.gnome.org/gio/unstable/ch32.html
Comment 1 Vadim Rutkovsky 2013-07-29 11:09:55 UTC
Yes, its a temporary solution, we're currently blocked on bug 656330
Comment 2 lltp 2016-01-09 18:17:50 UTC
#656330 might be solved already
Comment 3 Felipe Borges 2016-02-19 11:07:49 UTC
The only component of Music that depends on dbus-python is the MPRIS plugin. 

See also https://bugzilla.gnome.org/show_bug.cgi?id=759751
Comment 4 Michael Catanzaro 2016-02-19 18:24:04 UTC
*** Bug 759751 has been marked as a duplicate of this bug. ***
Comment 5 Matthias Clasen 2016-03-08 02:57:21 UTC
dropping dependency cleanup bugs from the target list at this point
Comment 6 Gaurav Narula 2016-03-16 22:01:26 UTC
Created attachment 324146 [details] [review]
Port MPRIS to pydbus

Ported MPRIS from dbus-python to pydbus.

Relevant Links:
https://github.com/LEW21/pydbus
https://dbus.freedesktop.org/doc/dbus-specification.html#idp94392448
https://specifications.freedesktop.org/mpris-spec/latest/

I'm not sure how to go about adding pydbus as a dependency and therefore the patch doesn't address that.
Comment 7 Gaurav Narula 2016-03-18 17:26:54 UTC
Created attachment 324293 [details] [review]
Port MPRIS to Gio GDBUS API

After Felipe's suggestion on IRC "it is always better to use our own stack", turns out it's possible to drop the need for pydbus altogether.
Comment 8 Bastien Nocera 2016-03-18 18:07:06 UTC
(In reply to Gaurav Narula from comment #7)
> Created attachment 324293 [details] [review] [review]
> Port MPRIS to Gio GDBUS API
> 
> After Felipe's suggestion on IRC "it is always better to use our own stack",
> turns out it's possible to drop the need for pydbus altogether.

It reduces the dependencies, but pydbus is a "Pythonic" API on top of GDBus, so if it had been a lot of work to port it, I would have advised not to port the code, but as it's already done.
Comment 9 Gaurav Narula 2016-03-18 20:06:46 UTC
Created attachment 324303 [details] [review]
Handle an edge case in GetAll

The edge case wasn't picked up by MPRISTester but was rather detected while using a Shell Extension.
Comment 10 Felipe Borges 2016-04-04 08:31:11 UTC
Review of attachment 324293 [details] [review]:

looks good.
Comment 11 Felipe Borges 2016-04-04 08:31:39 UTC
Review of attachment 324303 [details] [review]:

sure.
Comment 12 Felipe Borges 2016-04-04 08:33:18 UTC
Thanks for your patch.