After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756221 - Disabling application menu adds a redundant toolbar
Disabling application menu adds a redundant toolbar
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.18.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-08 04:52 UTC by Bastián Díaz
Modified: 2015-10-08 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (3.99 KB, image/png)
2015-10-08 04:52 UTC, Bastián Díaz 		  Details
main-window: Don't show an extra menu when the app menu is disabled (835 bytes, patch)
2015-10-08 08:28 UTC, Alessandro Bono 		none Details | Review
main-window: Don't show an extra menu when the app menu is disabled (851 bytes, patch)
2015-10-08 08:39 UTC, Debarshi Ray 		committed Details | Review

Description Bastián Díaz 2015-10-08 04:52:56 UTC 
Created attachment 312880 [details]
screenshot

See: Bug 754426

Disabling the application menu with "gnome-tweak-tool", an additional bar appears with a redundant menu.

fedora 23 beta 64 bit
gnome 3.18.0
gnome photos 3.18

Cheers
Comment 1 Alessandro Bono 2015-10-08 08:28:30 UTC 
Created attachment 312893 [details] [review]
main-window: Don't show an extra menu when the app menu is disabled
Comment 2 Debarshi Ray 2015-10-08 08:39:11 UTC 
Review of attachment 312893 [details] [review]:

::: src/photos-main-window.c
@@ +466,3 @@
                        "title", _(PACKAGE_NAME),
                        "window-position", GTK_WIN_POS_CENTER,
+		       "show-menubar", FALSE,

Nit: a few tabs managed to sneak in. :)
Comment 3 Debarshi Ray 2015-10-08 08:39:56 UTC 
Created attachment 312894 [details] [review]
main-window: Don't show an extra menu when the app menu is disabled

Replace the tabs with spaces
Comment 4 Debarshi Ray 2015-10-08 08:40:30 UTC 
Comment on attachment 312894 [details] [review]
main-window: Don't show an extra menu when the app menu is disabled

Thanks for the patch, Alessandro.