GNOME Bugzilla – Bug 754426
Disabling application menu adds a redundant toolbar
Last modified: 2016-03-31 13:22:07 UTC
Created attachment 310456 [details] Aplication menu x2 To use tweak tool to disable the application menu in the shell, this is duplicated in the user interface in boxes. Thanks
That's the expected behaviour: there are platforms that do not support the application menu outside of the application's window, so the toolkit will put it into the application's window. The menu has to go somewhere.
Actually, no: you're right — I didn't see the icon. That's where the app menu should be.
(In reply to Emmanuele Bassi (:ebassi) from comment #2) > Actually, no: you're right — I didn't see the icon. That's where the app > menu should be. The app menu is there, just above it. Not sure what's causing this though.
Bastián, did you change the decoration button layout setting as well? Does it contain the 'menu' identifier?
Seems like a GTK+ bug. Re-assigning.
Given that this only happens in boxes, I'm tempted to move it back. You must be doing something wrong...
(In reply to Emmanuele Bassi (:ebassi) from comment #4) > Bastián, did you change the decoration button layout setting as well? Does > it contain the 'menu' identifier? I do not quite understand the question. I have not made any changes. All I did in recent days went install the arc theme (GTK and shell) installed as dependency "gtk-engine-murrine". I uninstalled the issue and the problem persists. I must clarify that this problem is specific to gnome-boxes. I'm not very technical, but if I can do something to give further information I would like to guide me. Cheersa
It has nothing to do with murrine - it happens on my Fedora machine too, with Adwaita. But only in boxes, as you say.
the problem is that boxes sticks its headerbar in a stack, instead of directly putting it in the titlebar spot. we are smart enough to make the headerbar show the icon even when it is hidden like that, but apparently not smart enough to make the window not show its menubar. As a short-term workaround, I would recommend simple setting GtkApplicationWindow::show-menubar to FALSE.
(In reply to Matthias Clasen from comment #9) > the problem is that boxes sticks its headerbar in a stack, instead of > directly putting it in the titlebar spot. we are smart enough to make the > headerbar show the icon even when it is hidden like that, but apparently not > smart enough to make the window not show its menubar. As a short-term > workaround, I would recommend simple setting > GtkApplicationWindow::show-menubar to FALSE. Actually that is already being done: https://git.gnome.org/browse/gnome-boxes/tree/data/ui/app-window.ui#n35 .
Yet, when I look at the appwindow in the inspector, show-menubar is TRUE, and setting it to FALSE makes the menubar disappear.
(In reply to Matthias Clasen from comment #11) > Yet, when I look at the appwindow in the inspector, show-menubar is TRUE, > and setting it to FALSE makes the menubar disappear. Is it possible that gtk+ has a bug on getting this from UI description? I grepped the sources and this property is only set once from the UI file.
(In reply to Zeeshan Ali (Khattak) from comment #12) > (In reply to Matthias Clasen from comment #11) > > Yet, when I look at the appwindow in the inspector, show-menubar is TRUE, > > and setting it to FALSE makes the menubar disappear. > > Is it possible that gtk+ has a bug on getting this from UI description? I > grepped the sources and this property is only set once from the UI file. Indeed, if i set it from code, it works.
Oh, this is because you have a template there, and show-menubar is a construct property. templates can't set construct properties.
(In reply to Matthias Clasen from comment #14) > Oh, this is because you have a template there, and show-menubar is a > construct property. templates can't set construct properties. Oh? Is there a bug about it? I think gtk+ should warn about it.
Created attachment 311808 [details] [review] app-window: Set 'show-menubar' from vala Apparently construct properties can't be set from templates currently so this property never gets set and we end up with a redundant topbar and menu if "Show application menu" is disabled through tweak-tool. ---- I pushed this patch to master but not 3.18 yet since it's frozen.
Attachment 311808 [details] pushed as 72a2628 - app-window: Set 'show-menubar' from vala