After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756132 - GtkColorChooser doesn't let the user pick a color on the screen
GtkColorChooser doesn't let the user pick a color on the screen
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Widget: GtkColorChooser
3.22.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
: 775889 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-10-06 17:11 UTC by Arnaud Bienner
Modified: 2017-12-08 02:46 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Arnaud Bienner 2015-10-06 17:11:50 UTC
Unlike GtkColorSelectionDialog (which is deprecated), GtkColorChooser doesn't let the user select a color on the screen i.e. click one part of the screen to set the selected color to this one.

IMHO this was a nice feature, and it would be preferable to have as part of the color picker widget instead of having the need for each developer to implement its own solution.

Or should this be WONFIX and developers should use GtkColorSelectionDialog for this purpose? (even if it is deprecated). IMHO, seems to be the new GTK color picker, it seems more coherent if every GTK3 application uses it, that it would be better to have this feature as part of GtkColorChooser.
Comment 1 Emmanuele Bassi (:ebassi) 2015-10-06 17:13:58 UTC
This feature is really not going to be implementable on all platforms — basically, only on X11.

On Wayland, it would need a specific protocol extension to talk to the compositor. I'm not sure this would be implementable on OSX and Windows.
Comment 2 Arnaud Bienner 2015-10-06 17:23:39 UTC
To complete my description:
I worked on implementing the HTML5 attribute <input type="color"> on Firefox, which uses the native platform widget.
This meant GtkColorSelectionDialog on Linux/GTK, until recently when we migrated to GTK3 and someone migrated to GtkColorChooser.

One of the cool features of input type color was (in addition of native look and feel over javascript based implementation) the possibility for users to select a color on the screen (OS X color picker does it too, but not Windows), which otherwise would not be possible at all for a Web application.

I don't mean to ask for the feature just for my specific use case, but just wanted to give an example :) (but I'm sure it would be useful for other developers too).
Comment 3 Arnaud Bienner 2015-10-06 17:26:24 UTC
(In reply to Emmanuele Bassi (:ebassi) from comment #1)
> This feature is really not going to be implementable on all platforms —
> basically, only on X11.
> 
> On Wayland, it would need a specific protocol extension to talk to the
> compositor. I'm not sure this would be implementable on OSX and Windows.


Do you think it would be worth to implement it only on supported platform? (X11 in a first time at least).
I know this means less coherency (which is bad) but I really believe this feature can be useful.
Comment 4 Arnaud Bienner 2015-10-06 17:28:09 UTC
(for reference, the bug on Mozilla's bugzilla when we started to discuss about this issue for our use case: https://bugzilla.mozilla.org/show_bug.cgi?id=1198256)
Comment 5 Matthias Clasen 2015-10-07 01:58:50 UTC
If somebody is interested enough to produce a patch, I wouldn't be fundamentally opposed. The color picker code still exists in gtk/deprecated/gtkcolorsel.c.

I would expect the picker to be placed in the color editor, on platforms that support it. The code should ideally be kept separate in a private gtkcolorpicker widget. Bonus points for arranging things so that the deprecated colorselection uses the same code.
Comment 6 Emmanuele Bassi (:ebassi) 2016-12-09 16:03:02 UTC
*** Bug 775889 has been marked as a duplicate of this bug. ***
Comment 7 matheus4551 2017-12-05 01:51:55 UTC
The new color chooser is a whole regression compared to GtkColorSelectionDialog, in every user case. I suggest a revert, and i think many users would be happy with that.
Comment 8 Daniel Boles 2017-12-05 09:49:42 UTC
But that's not what this bug is about.

Besides, it is nowhere near as easy to revert to a GTK+ 2 widget from a technical or desirable from a code/UI design perspective (i.e. I doubt any maintainer will want to do so).
Comment 9 Matthias Clasen 2017-12-08 02:46:53 UTC
Since nobody has stepped forward in the 2 years since comment 5, lets close this for now.