After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756123 - Rename "Recent" view to "Books" or "Documents"
Rename "Recent" view to "Books" or "Documents"
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.17.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-06 14:12 UTC by Alessandro Bono
Modified: 2015-10-06 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
embed: Rename "Recent" view (1.01 KB, patch)
2015-10-06 16:29 UTC, Alessandro Bono 		committed Details | Review

Description Alessandro Bono 2015-10-06 14:12:25 UTC 
because we are planning to make the view sortable (bug 683563) and it is consistent with gnome-videos (totem).
Comment 1 Debarshi Ray 2015-10-06 16:17:24 UTC 
Looking at https://bugzilla.gnome.org/show_bug.cgi?id=729072#c13 , I think "Documents" would be correct replacement for "Recent".
Comment 2 Alessandro Bono 2015-10-06 16:29:07 UTC 
Created attachment 312747 [details] [review]
embed: Rename "Recent" view
Comment 3 Debarshi Ray 2015-10-06 16:50:18 UTC 
Review of attachment 312747 [details] [review]:

Thanks, Alessandro.

::: src/embed.js
@@ +78,3 @@
         // now create the actual content widgets
         this._documents = new View.ViewContainer(WindowMode.WindowMode.DOCUMENTS);
+        let label = !Application.application.isBooks ? _("Documents") : _('Books');

I don't like our current use of !isBooks when we could have easily written it without the negation, but that's for another day. Not a blocker.