After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729072 - Rename "Recent" view to "Photos"
Rename "Recent" view to "Photos"
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-27 20:11 UTC by Luis Henrique Mello
Modified: 2015-10-27 12:24 UTC
See Also:
GNOME target: ---
GNOME version: 3.13/3.14


Attachments
Change Recent to All (1.10 KB, patch)
2015-01-02 17:12 UTC, Robert Roth
committed Details | Review
embed: Rename "Recent" view to "Photos" (1.13 KB, patch)
2015-10-09 11:50 UTC, Debarshi Ray
committed Details | Review
tests: Update the test case (779 bytes, patch)
2015-10-27 12:24 UTC, Debarshi Ray
committed Details | Review

Description Luis Henrique Mello 2014-04-27 20:11:37 UTC
Under this tab, gnome-photos does not actually show recently displayed pictures, but everything tracker finds. So it's a similar situation with https://bugzilla.gnome.org/show_bug.cgi?id=725337 - 'Photos' or 'Library' would be proper names.
Comment 1 Debarshi Ray 2014-04-28 08:57:23 UTC
(In reply to comment #0)
> Under this tab, gnome-photos does not actually show recently displayed
> pictures

The items are sorted in decreasing order of their modification time.
Comment 2 Vishnu Naroth Kandoth 2014-06-02 03:08:08 UTC
I would like to work on this bug please assign it to me.
Comment 3 Debarshi Ray 2014-06-02 09:04:32 UTC
(In reply to comment #2)
> I would like to work on this bug please assign it to me.

But we have not decided whether we really want to change the name.
Comment 4 Allan Day 2014-11-20 10:32:39 UTC
"All" is another contender...
Comment 5 Robert Roth 2015-01-02 13:20:40 UTC
@Debarshi Ray: What do you think about Allan's suggestion?
Comment 6 Debarshi Ray 2015-01-02 13:44:31 UTC
(In reply to comment #5)
> @Debarshi Ray: What do you think about Allan's suggestion?

I am fine with "All" if we have consensus.
Comment 7 Robert Roth 2015-01-02 17:12:39 UTC
Created attachment 293610 [details] [review]
Change Recent to All
Comment 8 Robert Roth 2015-02-10 07:26:45 UTC
@Debarshi Ray: could I get a review on the patch from comment 7, as we seem to have consensus on "All".
Comment 9 Debarshi Ray 2015-02-10 08:37:47 UTC
It is not clear to me why "Recent" is problematic, and nobody has tried to clearly state what the problem is. We do show the items in decreasing order of their modification times. "All" could also work, but why do we need to change it in the first place?
Comment 10 Luis Henrique Mello 2015-04-11 12:04:13 UTC
(In reply to Debarshi Ray from comment #9)
> It is not clear to me why "Recent" is problematic, and nobody has tried to
> clearly state what the problem is. We do show the items in decreasing order
> of their modification times. "All" could also work, but why do we need to
> change it in the first place?

I see it - this view is meant to replicate gnome-documents' and gnome-books' - for example, the program does not actually moves to the Trash an icon you select from the Recent view and 'delete' it. It simply removes the photo from the list.

But should it? Since this is a different matter altogether and involves coherence from other GNOME software - for instance, the redesigned totem DOES delete (move to Trash) videos when doing the exact same thing.
Comment 11 Debarshi Ray 2015-04-13 09:08:07 UTC
(In reply to Luis Henrique Mello from comment #10)
> I see it - this view is meant to replicate gnome-documents' and gnome-books'
> - for example, the program does not actually moves to the Trash an icon you
> select from the Recent view and 'delete' it. It simply removes the photo
> from the list.

Items do get deleted if don't undo the delete operation. So does gnome-documents. Recently we changed it to use the trash instead of deleting permanently. See bug 747183

In any case, how is that relevant to this bug?

To be clear, I don't have a strong opinion on what this view should be called, and I don't want to change the string unless there is a clear agreement on the name. In case we decide not to change the name, we will close it as NOTABUG, but let's not close the bug without any good reason.

Reopening.
Comment 12 Debarshi Ray 2015-04-13 12:32:50 UTC
Apple calls it "Photos": https://www.apple.com/osx/photos/
Comment 13 Allan Day 2015-06-17 16:04:19 UTC
We've been using "Photos" in the latest mockups too.
Comment 14 Debarshi Ray 2015-10-09 11:50:10 UTC
Created attachment 312946 [details] [review]
embed: Rename "Recent" view to "Photos"
Comment 15 Debarshi Ray 2015-10-27 12:24:20 UTC
Created attachment 314218 [details] [review]
tests: Update the test case