GNOME Bugzilla – Bug 682692
off-by-one drawing bug
Last modified: 2018-03-21 20:27:06 UTC
Created attachment 222430 [details] typescript Steps: start vteapp and cat the attached typescript Results: the QR code has a black 1px line at the right hand that's not there in the data; all the lines end in a U+2588 FULL BLOCK character.
Created attachment 222431 [details] screenshot
Created attachment 222433 [details] [review] drawing: Don't overdraw the cell on bold characters
Created attachment 222434 [details] [review] drawing: Don't overdraw the cell on bold characters This was added in comment dcb7fd974bea5fe49d4f5b0344ebdaffc6d7bae1 and apparently used for pseudo-bold, which we don't do anymore.
Fixed on 0-34 and next.
This doesn't look fully fixed to me. In case of faux bold, the background is still extended by 1px in ::draw_cells() gint bold_offset = _vte_draw_has_bold(...); _vte_draw_fill_rectangle(..., w + bold_offset, ...); and once again in ::draw_rows. How about we entirely drop this idea of extending the background color, just let the faux bold overflow from its background (as it already happens for every glyph that's just wider than the standard English ones) (and make _vte_draw_has_bold private/static to vtedraw)? (... or drop faux bold?)
(In reply to Egmont Koblinger from comment #5) > How about we entirely drop this idea of extending the background color, just > let the faux bold overflow from its background (as it already happens for > every glyph that's just wider than the standard English ones) Good idea.
Created attachment 369955 [details] [review] Don't extend the background on faux bold How to test: Pick a font that doesn't have bold counterpart, maybe because it's already bold: ./src/app/vte-2.91 -f 'Monospace Bold 10' Produce some bold and non-bold text with background whose right column should be aligned, e.g. ./perf/sgr-test.sh Notice that the right edge of the purple background didn't align prior to this patch, but aligns now. This is the first of two patches, the second one goes into bug 756010.
Comment on attachment 369955 [details] [review] Don't extend the background on faux bold Master only, please. Thanks for the patch!
> Master only, please. Obviously! :) Submitted.