After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755873 - A series of patches to make tests pass with GLib ≥ 2.45.7
A series of patches to make tests pass with GLib ≥ 2.45.7
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-30 11:56 UTC by Dmitry Shachnev
Modified: 2015-10-07 15:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests: Fix name of note-xdg-schema-without-schema-locked (1.28 KB, patch)
2015-09-30 11:58 UTC, Dmitry Shachnev
none Details | Review
tests: Make sure names for write_large_file tests are different (1.06 KB, patch)
2015-09-30 11:58 UTC, Dmitry Shachnev
none Details | Review
egg: Make sure names for encode-decode tests are different (901 bytes, patch)
2015-09-30 11:58 UTC, Dmitry Shachnev
none Details | Review
build: Make tap-gtester handle skipped tests correctly (1.10 KB, patch)
2015-09-30 11:59 UTC, Dmitry Shachnev
none Details | Review

Description Dmitry Shachnev 2015-09-30 11:56:38 UTC
There were some recent changes in GLib (see bug 754286) which broke gnome-keyrinng tests:

1) As of glib commit 367f36d6, different tests with the same full path are forbidden. We were using that in multiple places.

2) As of glib commit 123ea70d, the output for skipped tests changed, and our tap-gtester should be adopted to work with the new output.
Comment 1 Dmitry Shachnev 2015-09-30 11:58:06 UTC
Created attachment 312421 [details] [review]
tests: Fix name of note-xdg-schema-without-schema-locked
Comment 2 Dmitry Shachnev 2015-09-30 11:58:32 UTC
Created attachment 312422 [details] [review]
tests: Make sure names for write_large_file tests are different
Comment 3 Dmitry Shachnev 2015-09-30 11:58:58 UTC
Created attachment 312423 [details] [review]
egg: Make sure names for encode-decode tests are different
Comment 4 Dmitry Shachnev 2015-09-30 11:59:20 UTC
Created attachment 312424 [details] [review]
build: Make tap-gtester handle skipped tests correctly
Comment 5 Dmitry Shachnev 2015-10-07 15:16:52 UTC
Thanks Stef for pushing the patches!