After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754286 - misc gtestutils fixes
misc gtestutils fixes
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-08-29 14:13 UTC by Dan Winship
Modified: 2015-08-31 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtestutils: improve non-TAP output, fix handling of incomplete tests (2.61 KB, patch)
2015-08-29 14:13 UTC, Dan Winship 		committed Details | Review
gtestutils: forbid having two tests with the same full path (3.59 KB, patch)
2015-08-29 14:13 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2015-08-29 14:13:29 UTC 
Given that the "forbid having two tests with the same full path" patch
broke two tests in GLib, maybe it should just be a non-fatal warning
for now?
Comment 1 Dan Winship 2015-08-29 14:13:33 UTC 
Created attachment 310258 [details] [review]
gtestutils: improve non-TAP output, fix handling of incomplete tests

In non-TAP mode, tests that used g_test_skip() were labelled "OK", and
tests that used g_test_incomplete() were labelled "FAIL". Explicitly
show them as "SKIP" and "TODO" instead, like in the TAP case.

Also, incomplete/TODO tests are not supposed to be treated as
failures, so fix that too.
Comment 2 Dan Winship 2015-08-29 14:13:37 UTC 
Created attachment 310259 [details] [review]
gtestutils: forbid having two tests with the same full path

In the same way that gtestutils used to let you create multiple suites
with the same name, it also let you create multiple tests with the
same name. Make that an error instead (and fix glib/tests/base64.c,
which was registering three separate tests named
"/base64/incremental/nobreak/4", and glib/tests/autoptr.c, which was
running test_g_variant_builder() twice).
Comment 3 Colin Walters 2015-08-29 16:53:19 UTC 
Review of attachment 310258 [details] [review]:

Looks reasonable.
Comment 4 Colin Walters 2015-08-29 16:54:00 UTC 
Review of attachment 310259 [details] [review]:

Looks good.
Comment 5 Dan Winship 2015-08-31 18:19:00 UTC 
Attachment 310258 [details] pushed as 123ea70 - gtestutils: improve non-TAP output, fix handling of incomplete tests
Attachment 310259 [details] pushed as 367f36d - gtestutils: forbid having two tests with the same full path