After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754700 - Use album artist when dealing with multi-artist album (if available)
Use album artist when dealing with multi-artist album (if available)
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 758671 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-09-07 18:54 UTC by p.oliveira.castro
Modified: 2016-06-23 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
"2pac feat Danny Boy, Big Syke & C.P.O." is unexpected. (126.41 KB, image/png)
2015-09-07 18:54 UTC, p.oliveira.castro
  Details
query: Remove unused coalesce statements (1.41 KB, patch)
2016-05-27 08:52 UTC, Marinus Schraal
none Details | Review
Use album-artist if available (13.29 KB, patch)
2016-05-27 08:52 UTC, Marinus Schraal
none Details | Review

Description p.oliveira.castro 2015-09-07 18:54:16 UTC
Created attachment 310857 [details]
"2pac feat Danny Boy, Big Syke & C.P.O." is unexpected.

I have an album by various artists (actually, each track of thee album features different artists). In Artist view, the album is put inside a single artist. This is a good idea, since I don't want to have "2pac feat. Snoop Dog" and "2pac feat. Danny Boy" as two separate artists.

However, the whole album is grouped inside an arbitrary artist, that doesn't represent the whole album. I expected to see the album inside the "Album Artist" (if available). In my example, I would have "2pac" inside Artists view, instead of "2pac feat Danny Boy, Big Syke & C.P.O." (see screenshot).
Comment 1 Felipe Borges 2016-02-22 08:58:08 UTC
*** Bug 758671 has been marked as a duplicate of this bug. ***
Comment 2 Marinus Schraal 2016-02-23 20:35:33 UTC
The patch in https://bugzilla.gnome.org/show_bug.cgi?id=761625 should probably fix this problem. It should use the albumArtist where appropriate.

Could you maybe test it?
Comment 3 Marinus Schraal 2016-05-23 10:28:17 UTC
This should be fixed in git from master, could you please test it?
Comment 4 Marinus Schraal 2016-05-23 10:36:42 UTC
(In reply to Marinus Schraal from comment #3)
> This should be fixed in git from master, could you please test it?

Ignore this, still needs a patch.
Comment 5 Marinus Schraal 2016-05-27 08:52:42 UTC
Created attachment 328631 [details] [review]
query: Remove unused coalesce statements
Comment 6 Marinus Schraal 2016-05-27 08:52:59 UTC
Created attachment 328632 [details] [review]
Use album-artist if available

Album songs can be tagged with an album-artist tag, which indicates the
main artist of an album. Individual songs on an album can have a
different artist tag: the performer(s) on that track. Using album-artist
for display or sorting is preferrable in most cases.
Comment 7 Marinus Schraal 2016-05-27 09:02:01 UTC
These patches need grilo-plugins from master and the patch from bug #766587 to truly work. Please test.

Also please attach output of 'tracker info <music file>' of one of the songs on an offending album.
Comment 8 Marinus Schraal 2016-06-07 22:08:52 UTC
Patches have been pushed. It should solve some of the problems, please test. If issues persist please open a fresh bug.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 9 Cédric Bellegarde 2016-06-20 15:03:27 UTC
The issue is really more complexe:
- Album with no album artist and different artists are compilations
- Album artists can have many artist
- Performers can have many performers
Comment 10 Marinus Schraal 2016-06-21 16:55:57 UTC
(In reply to Cédric Bellegarde from comment #9)
> The issue is really more complexe:
> - Album with no album artist and different artists are compilations

It should then have 'various artist' or similar as album artist. Albums with no album-artist and different artists have no other unique tags (other than title, which is unreliable) to match them.

> - Album artists can have many artist

'album artist' usually means 1 main artist in most tags.

> - Performers can have many performers

True, nmm:performer is the tracker ontology naming of what we consider the track artist(s) and can be more than one. Confusing and not clear from my earlier comment.


Tagging is sadly a completely subjective art, with only some vaguely accepted guidelines.

If you have problems with how gnome-music git displays albums/tracks, please do file a fresh bug per issue. Preferably with full 'tracker info' on the problematic tracks attached.
Comment 11 Cédric Bellegarde 2016-06-23 14:16:47 UTC
>Albums with no album-artist and different artists have no other unique tags 
>(other than title, which is unreliable) to match them.

You match them as "Compilations" (Translated), not a static english "Various artist". Works like this in Amarok, Clementine, Lollypop, ...

>'album artist' usually means 1 main artist in most tags.

Yes, but I have albums with two artists:
http://cs605926.vk.me/v605926369/61c8/AmLnkSVy9Io.jpg
In this case, you should see:
- In artist view, tracks from 2pac in 2pac and tracks from snoop in Snoop Doggy Dog
- In album view, one album with 2pac/Snoop Doggy Dog as album artist


It was a pain for me to implement this in Lollypop, so take this in account sooner than me:
https://github.com/gnumdk/lollypop/issues/507
Comment 12 Cédric Bellegarde 2016-06-23 14:24:06 UTC
>Albums with no album-artist and different artists have no other unique tags 
>(other than title, which is unreliable) to match them.

Ok, I know why you said that.

It shoulds be handled like this:
- Albums with "Name" and "Year", without album artists and with different artists are compilations 
- Albums with "Name" and "Year", without album artists and with same artists are albums
- Albums with "Name" and "Year" with album artists are albums