After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766587 - tracker: Add album artist key mapping
tracker: Add album artist key mapping
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-05-17 22:49 UTC by Marinus Schraal
Modified: 2016-05-29 08:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tracker: Add album artist key mapping (1.06 KB, patch)
2016-05-17 22:49 UTC, Marinus Schraal 		none Details | Review
tracker: Add album artist key mapping (1.47 KB, patch)
2016-05-27 08:47 UTC, Marinus Schraal 		none Details | Review
tracker: Indentation fix (939 bytes, patch)
2016-05-27 14:20 UTC, Marinus Schraal 		committed Details | Review
tracker: Add album artist key mapping (1.06 KB, patch)
2016-05-27 14:20 UTC, Marinus Schraal 		committed Details | Review

Description Marinus Schraal 2016-05-17 22:49:53 UTC 
Map nmm:albumArtist to GRL_METADATA_KEY_ALBUM_ARTIST.
Comment 1 Marinus Schraal 2016-05-17 22:49:58 UTC 
Created attachment 328107 [details] [review]
tracker: Add album artist key mapping
Comment 2 Bastien Nocera 2016-05-18 09:31:34 UTC 
Review of attachment 328107 [details] [review]:

Is that's been tested, looks fine to me.
Comment 3 Marinus Schraal 2016-05-27 08:47:24 UTC 
Created attachment 328630 [details] [review]
tracker: Add album artist key mapping

Map nmm:albumArtist to GRL_METADATA_KEY_ALBUM_ARTIST.
Comment 4 Marinus Schraal 2016-05-27 08:49:31 UTC 
It has been tested. Updated the patch to apply on master.
Comment 5 Bastien Nocera 2016-05-27 10:04:01 UTC 
Review of attachment 328630 [details] [review]:

::: src/tracker/grl-tracker-utils.c
@@ +205,3 @@
                       "audio");
 
+  insert_key_mapping (GRL_METADATA_KEY_ALBUM_DISC_NUMBER,

Why is this line changing? If you need to change it, it needs to be in a separate commit.
Comment 6 Marinus Schraal 2016-05-27 14:20:05 UTC 
Created attachment 328643 [details] [review]
tracker: Indentation fix
Comment 7 Marinus Schraal 2016-05-27 14:20:40 UTC 
Created attachment 328644 [details] [review]
tracker: Add album artist key mapping

Map nmm:albumArtist to GRL_METADATA_KEY_ALBUM_ARTIST.
Comment 8 Bastien Nocera 2016-05-27 15:46:35 UTC 
Review of attachment 328643 [details] [review]:

Sure.
Comment 9 Bastien Nocera 2016-05-27 15:46:57 UTC 
Review of attachment 328644 [details] [review]:

Looks good.