After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754190 - Hiding completed modules is broken in user profile
Hiding completed modules is broken in user profile
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-08-27 17:17 UTC by Tom Tryfonidis
Modified: 2015-09-26 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "Hide completed modules" in user page and all modules page (4.71 KB, patch)
2015-09-26 11:03 UTC, gregoire 		committed Details | Review

Description Tom Tryfonidis 2015-08-27 17:17:06 UTC 
Recent changes about "Hide completed modules" (bug #660005) broke this functionality in user profile.

Page 'complains' about showHideCompleted() function, which is no longer available after this commit [1]

[1] https://git.gnome.org/browse/damned-lies/commit/?id=840e021a13bbcc0c3c280c0f38cd12b82a1e443a


Adding the correct links could possibly fix this problem:

<a href="#" id="hide-completed-modules">{% trans "Hide completed modules" %}</a>
<a href="#" id="show-completed-modules" style="display: none;">{% trans "Show completed modules" %}</a>
Comment 1 gregoire 2015-09-26 11:03:10 UTC 
Created attachment 312189 [details] [review]
Fix "Hide completed modules" in user page and all modules page
Comment 2 Claude Paroz 2015-09-26 14:26:00 UTC 
Review of attachment 312189 [details] [review]:

Great, thank you very much. Committed and deployed