After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660005 - Remember "Hide completed modules" setting on page refresh
Remember "Hide completed modules" setting on page refresh
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-24 13:12 UTC by TLE
Modified: 2015-08-10 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remember "Hide completed modules" (8.51 KB, patch)
2015-08-10 15:34 UTC, gregoire
committed Details | Review

Description TLE 2011-09-24 13:12:29 UTC
Hallo damned lies devs

This a just a low priority wish list bug. It would be nice if the overview pages like e.g. http://l10n.gnome.org/languages/da/gnome-3-2/ui/ could remember the "Hide completed modules" setting when you refresh the page. I guess in php you would do it by adding it as a URI option "http://l10n.gnome.org/languages/da/gnome-3-2/ui/?hide_complete=1" or something, but I have no idea of how to do it in Django or if it can even be done.

Regards Kenneth
Comment 1 Claude Paroz 2011-09-24 14:48:44 UTC
This should be implemented client-side only, for example with a library like https://github.com/carhartl/jquery-cookie
Comment 2 Adorilson Bezerra 2011-09-26 04:14:27 UTC
I really would like to see this bug resolved.
Comment 3 Claude Paroz 2011-09-26 06:15:11 UTC
(In reply to comment #2)
> I really would like to see this bug resolved.

I'm looking forward to your patch :-)
Comment 4 TLE 2011-09-26 09:04:29 UTC
I wouldn't mind working on this. But I'm going to need some mentoring (mostly about the structure of damned-lies and how to get my own copy running, so that I can test it), so I don't know if it will be an advantage time wise.
Comment 5 Claude Paroz 2011-09-26 09:23:00 UTC
Kenneth, my comment was addressed to Adorilson, because I know he can do it (he already provided patches for D-L).
Comment 6 TLE 2011-09-26 09:43:37 UTC
Claude: I know I got that. I was just saying that I wouldn't mind, but I won't do it if you think it is going to be much bother for you guys. I do have some Python/php experience, but none with website programming with python toolkits.
Comment 7 Claude Paroz 2011-09-26 09:48:40 UTC
In fact, this feature should only require client-side programming (jquery). Adding a jquery plugin, setting the cookie when one click on the link, get the cookie on $(document).ready and acting accordingly.
Comment 8 gregoire 2015-08-10 15:34:51 UTC
Created attachment 309016 [details] [review]
Remember "Hide completed modules"

* refactor the javascript come to use jquery
* add the module jquery.cookie.js
* stores the current state in a cookie.
Comment 9 Claude Paroz 2015-08-10 16:28:20 UTC
Review of attachment 309016 [details] [review]:

Thanks, excellent patch.