After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753296 - require libical >= 1.0.1 for icaltime_days_in_year()
require libical >= 1.0.1 for icaltime_days_in_year()
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
3.16.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
: 752626 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-08-05 20:16 UTC by Anders Jonsson
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Anders Jonsson 2015-08-05 20:16:07 UTC 
Bug 751244 stated a dependency on libical >= 1.0 to build gnome-calendar.

However 1.0 is not quite enough. A typo (ycaltime_days_in_year) in 1.0.0 makes the function unusable. I noticed this on the version of 1.0 that Debian uses (1.0-1.3). This version passes the checks of configure.ac, but make fails because of the misspelled function.


The typo is fixed in https://github.com/libical/libical/commit/60ebe54f7a3bb26f31234a1efe42759589453de2 and included in libical 1.0.1.


Thus libical 1.0.1 would be a good requirement both for master, and also the gnome-3-16 branch, as gnome-calendar uses the icaltime_days_in_year function there as well.

Regards,
Anders Jonsson
Comment 1 Erick Perez Castellanos 2015-10-01 06:32:33 UTC 
*** Bug 752626 has been marked as a duplicate of this bug. ***
Comment 2 Erick Perez Castellanos 2015-10-01 06:39:14 UTC 
(In reply to Anders Jonsson from comment #0)
> Bug 751244 stated a dependency on libical >= 1.0 to build gnome-calendar.
> 
> However 1.0 is not quite enough. A typo (ycaltime_days_in_year) in 1.0.0
> makes the function unusable. I noticed this on the version of 1.0 that
> Debian uses (1.0-1.3). This version passes the checks of configure.ac, but
> make fails because of the misspelled function.
> 
> 
> The typo is fixed in
> https://github.com/libical/libical/commit/
> 60ebe54f7a3bb26f31234a1efe42759589453de2 and included in libical 1.0.1.
> 
> 
> Thus libical 1.0.1 would be a good requirement both for master, and also the
> gnome-3-16 branch, as gnome-calendar uses the icaltime_days_in_year function
> there as well.
> 
> Regards,
> Anders Jonsson

The problem with that is the developer of libical didn't bumped the version of the library in the pc file, so `pkg-config --modversion libical` output `1.0` even for libical-1.0.1
Comment 3 Erick Perez Castellanos 2015-10-06 13:38:38 UTC 
Pushed to master as commit d8265a4