GNOME Bugzilla – Bug 751244
require libical >= 1.0 for icaltime_days_in_year()
Last modified: 2017-04-17 18:20:40 UTC
(As reported downstream at https://bugs.gentoo.org/show_bug.cgi?id=552498) In vanilla unpatched libical 0.43 -- 0.48, icaltime_days_in_year() is declared in the header, but the implementation of the function is missing. As a result, attempting to build gnome-calendar against old libical versions fails at linking stage: gcal-event-widget.o: In function `gcal_event_widget_is_multiday': gcal-event-widget.c:(.text+0x1453): undefined reference to `icaltime_days_in_year' collect2: error: ld returned 1 exit status So gnome-calendar needs to check for libical >= 1.0 in configure.
Created attachment 305733 [details] [review] trivial patch
(In reply to Alexandre Rostovtsev from comment #0) > gcal-event-widget.o: In function `gcal_event_widget_is_multiday': > gcal-event-widget.c:(.text+0x1453): undefined reference to > `icaltime_days_in_year' > collect2: error: ld returned 1 exit status > > So gnome-calendar needs to check for libical >= 1.0 in configure. 1.0 is not quite enough. A typo (ycaltime_days_in_year) in 1.0.0 makes the function unusable. I noticed this on the version of 1.0 that Debian uses (1.0-1.3). The typo is fixed in https://github.com/libical/libical/commit/60ebe54f7a3bb26f31234a1efe42759589453de2 and included in libical 1.0.1. 1.0.1 would probably be a good requirement for the gnome-3-16 branch also, as gnome-calendar uses the icaltime_days_in_year function there as well.