GNOME Bugzilla – Bug 753170
Settings updates not received
Last modified: 2015-11-12 10:38:41 UTC
+++ This bug was initially created as a clone of Bug #753155 +++ Screen lock is currently not handled by the orientation plugin as it does not receive any changed:: notification. This is caused by not reading the variable after connecting the signal as listed in the documentation: https://bugzilla.gnome.org/show_bug.cgi?id=750257 This also happens in: - datetime - keyboard - media-keys - wacom - xsettings
Created attachment 308672 [details] [review] wacom: Read settings after connecting to changed:: According to GSettings docs, one must read after connecting to changed:: in order to ensure the handler will trigger in the future.
Created attachment 308673 [details] [review] xsettings: Read settings after connecting to changed:: According to GSettings docs, one must read after connecting to changed:: in order to ensure the handler will trigger in the future.
Created attachment 308674 [details] [review] datetime: Read settings after connecting to changed:: According to GSettings docs, one must read after connecting to changed:: in order to ensure the handler will trigger in the future.
From my inspection, the other appearances do things in the right order.
Review of attachment 308672 [details] [review]: Looks good.
Review of attachment 308673 [details] [review]: Yes.
Review of attachment 308674 [details] [review]: Looks good.
I double checked the other plugins, and it seems that they're not affected as you said in comment 4.
Attachment 308672 [details] pushed as 32b99b1 - wacom: Read settings after connecting to changed:: Attachment 308673 [details] pushed as 76dd2fc - xsettings: Read settings after connecting to changed:: Attachment 308674 [details] pushed as 946c3a9 - datetime: Read settings after connecting to changed::
Is there going to be a 3.16.4 release any time soon (with these commits included)? I ask because we were planning to do a maintenance release for openSUSE Leap 42.1 which ships GNOME 3.16 to bring all the GNOME apps to their latest upstream 3.16 states, and g-s-d has seen a few fixes since its last 3.16.3 release. Thanks!