After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753155 - orientation: Screen lock is ignored
orientation: Screen lock is ignored
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 753170
 
 
Reported: 2015-08-02 18:53 UTC by Jan-Michael Brummer
Modified: 2015-08-03 08:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change the read/connect flow for changed:: signal (1.44 KB, patch)
2015-08-02 18:53 UTC, Jan-Michael Brummer 		none Details | Review
orientation: Fix screen lock not getting applied (1.47 KB, patch)
2015-08-03 08:30 UTC, Bastien Nocera 		committed Details | Review

Description Jan-Michael Brummer 2015-08-02 18:53:45 UTC 
Created attachment 308636 [details] [review]
Change the read/connect flow for changed:: signal

Screen lock is currently not handled by the orientation plugin as it does not receive any changed:: notification. This is caused by not reading the variable after connecting the signal as listed in the documentation:

https://bugzilla.gnome.org/show_bug.cgi?id=750257

Attached patch reorders the execution flow and finally respects screen rotation lock on my Dell Venue 11 Pro tablet.
Comment 1 Bastien Nocera 2015-08-03 08:30:59 UTC 
Created attachment 308653 [details] [review]
orientation: Fix screen lock not getting applied

Read value after connecting to changed:: signal, as it's a requirement
for the signal to be emitted at all.

See https://bugzilla.gnome.org/show_bug.cgi?id=750257 for details.
Comment 2 Bastien Nocera 2015-08-03 08:32:58 UTC 
Attachment 308653 [details] pushed as 5541081 - orientation: Fix screen lock not getting applied